Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework community page #398

Merged
merged 3 commits into from Apr 21, 2020
Merged

Rework community page #398

merged 3 commits into from Apr 21, 2020

Conversation

davidak
Copy link
Member

@davidak davidak commented Apr 18, 2020

Here is my rework of the community page.

I mostly used the existing content, removed unrelated information and created a new layout.

It's not perfect, but better than before.

Feel free to suggest better wording.

@davidak davidak mentioned this pull request Apr 18, 2020
@github-actions
Copy link
Contributor

@davidak davidak requested a review from garbas April 18, 2020 12:34
Copy link
Member

@garbas garbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the page from /nixos/community.html to /community.html can be done in another PR.

Just add a redirect to netlify.toml, since once we merge the change goes public and it makes no sense to put it in a separate PR.

Removed content (and suggested new place):

  • Contributing to NixOS (Contribution Guide)

It would be good to open a issue for this, so we don't forget and list all the content that we removed from current community page.

  • Bugs (Help page and GitHub Readme)

Most likely Bugs should be also part of the Contribution guide, somewhere under Learn page.

  • Documentation (Documentation page)

You probably ment Learn page

  • Source repositories (Contribution Guide)
  • Commercial support (own site? but where to link? help page?)

I will add this topic to be discussed at the next meeting.

  • Donations (Donation page)

👍

  • Acknowledgments (Donation page)

👍

nixos/community.tt Outdated Show resolved Hide resolved
nixos/community.tt Outdated Show resolved Hide resolved
nixos/community.tt Outdated Show resolved Hide resolved
teams/nixcon.tt Outdated Show resolved Hide resolved
@davidak
Copy link
Member Author

davidak commented Apr 20, 2020

@garbas thanks for the feedback!

Just add a redirect to netlify.toml, since once we merge the change goes public

i made no change to the structure, just the content. but i can add it in this PR

Most likely Bugs should be also part of the Contribution guide, somewhere under Learn page.

Yes, it can be a section in a Contribution guide and we can link it from Learn page as "Report Bugs".

Documentation (Documentation page)

You probably ment Learn page

i mean any documentation page that fits. it's mostly links to NixOS manual, so learn might already cover it.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@davidak
Copy link
Member Author

davidak commented Apr 20, 2020

Just add a redirect to netlify.toml, since once we merge the change goes public and it makes no sense to put it in a separate PR.

I git mv nixos/community.tt community.tt and committed it to the same commit as the changes, but now it's saved as delete/create instead of rename and the actual changes to the text and page history are lost :(

I wanted to prevent that.

I added it as a second commit, but now i'm unable to edit the first commit.

@github-actions
Copy link
Contributor

nixos/community.tt Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@garbas garbas merged commit bf9097b into master Apr 21, 2020
@garbas garbas deleted the Community branch April 21, 2020 08:40
@rkoe
Copy link

rkoe commented Apr 23, 2020

I really dislike this merge. Nothing against a rework in general and nothing against your rework, davidak.

BUT: The merge was too early. Removing useful informations from the homepage is a bad idea. Now, there isn't a link to the bugtracker anywhere on the homepage, and effectively also no link to the github-repository anywhere! First, a new place should be found on the homepage for this information, and afterwards it can be removed from the current location. Not the other way round!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants