Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lektor: make available as application #85475

Closed
wants to merge 1 commit into from
Closed

lektor: make available as application #85475

wants to merge 1 commit into from

Conversation

das-g
Copy link
Member

@das-g das-g commented Apr 18, 2020

resolves #55820

Motivation for this change

because Lektor isn't only a library

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review 1

28 package marked as broken and skipped:
  • digitalbitbox
  • iterm2
  • linuxPackages_4_4.evdi
  • linuxPackages_hardkernel_4_14.bcc
  • linuxPackages_hardkernel_4_14.bpftrace
  • linuxPackages_hardkernel_4_14.can-isotp
  • linuxPackages_hardkernel_4_14.chipsec
  • linuxPackages_hardkernel_4_14.digimend
  • linuxPackages_hardkernel_4_14.evdi
  • linuxPackages_hardkernel_4_14.mba6x_bl
  • linuxPackages_hardkernel_4_14.nvidia_x11
  • linuxPackages_hardkernel_4_14.nvidia_x11_legacy390
  • linuxPackages_hardkernel_4_14.nvidiabl
  • linuxPackages_hardkernel_4_14.prl-tools
  • linuxPackages_hardkernel_4_14.r8168
  • muslCross
  • nix-linter
  • octave-jit
  • octoprint
  • php73Extensions.zmq
  • php74Extensions.couchbase
  • php74Extensions.pthreads
  • python27Packages.flitBuildHook
  • python27Packages.libmodulemd
  • python37Packages.nixpart
  • python37Packages.notify
  • python37Packages.pyblock
  • python38Packages.libselinux
1 package built:
  • lektor

(I guess the "skipped" packages are wrongly listed due to Mic92/nixpkgs-review#96.)

@das-g
lektor: make available as application
2468279 
because this isn't only a library

resolves NixOS#55820
@JohnAZoidberg
Copy link
Member

#85476 should be fixed first, see #55820 (comment)

@stale
Copy link

stale bot commented Dec 11, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 11, 2020
@Artturin
Copy link
Member

Artturin commented Feb 2, 2023

Reopen and rebase if you're still interested in this.

@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should Lektor be packaged as Python application?
3 participants
@das-g @JohnAZoidberg @Artturin