Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.simpleaudio: init at 1.0.4 #85435

Merged
merged 1 commit into from Apr 22, 2020
Merged

python3Packages.simpleaudio: init at 1.0.4 #85435

merged 1 commit into from Apr 22, 2020

Conversation

Lucus16
Copy link
Contributor

@Lucus16 Lucus16 commented Apr 17, 2020

Motivation for this change

The simpleaudio package has no other python library dependencies and is cross platform which makes it ideal for collaboration with people on other platforms.

Things done

python2Packages.simpleaudio fails to build, it's Python 3 only. Do I need to add something to indicate this?

  • Tested library works as expected in a simple python project.
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Apr 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

    File "setup.py", line 42, in <module>
      encoding='utf-8') as f:
  TypeError: 'encoding' is an invalid keyword argument for this function
cannot build derivation '/nix/store/sa2b025wzf4rgvic5x0zvrhqmwxqxmai-env.drv': 1 dependencies couldn't be built
[3 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/sa2b025wzf4rgvic5x0zvrhqmwxqxmai-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/85435
1 package failed to build:
python27Packages.simpleaudio

2 package built:
python37Packages.simpleaudio python38Packages.simpleaudio

pkgs/development/python-modules/simpleaudio/default.nix Show resolved Hide resolved
pkgs/development/python-modules/simpleaudio/default.nix Outdated Show resolved Hide resolved
@Lucus16
Copy link
Contributor Author

Lucus16 commented Apr 17, 2020

Resolved, thanks!

jonringer
jonringer approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 85435 1

1 package failed to build: - python27Packages.simpleaudio
2 package built: - python37Packages.simpleaudio - python38Packages.simpleaudio

@jonringer jonringer merged commit 800dd4b into NixOS:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lucus16 @jonringer