mailspring: init at 1.7.8 #85492

toschmidt · 2020-04-18T11:47:33Z

Motivation for this change

Packaged the mail client Mailspring at version 1.7.5

Mailspring is a new version of Nylas Mail maintained by one of the original authors. It's faster, leaner, and shipping today!

Currently two pull requests for mailspring at version 1.6.3 exist: #69384 and #69027

Syncing mails does not work in #69384 and #69027 uses buildFHSUserEnv although only one file needs patching.

This PR is based on the work done by rummik in #69384 and solves both problems for the latest version of mailspring.

The application needs gnome-keyring for storing passwords.

Things done

Notify maintainers

cc @

drewrisinger · 2020-04-28T21:59:22Z

Closes #69027 #69384
@GrahamcOfBorg build mailspring

drewrisinger

Thanks for submitting your first PR! This looks like a well-researched PR. I'm honestly not terribly familiar with the Linux binary side of nixpkgs, but I know the general preference is to build packages from scratch in Nixpkgs if possible.

There's some formatting/best practices included below.
Also, when trying to review this, I ran into a merge conflict with the maintainers list (probably b/c you submitted a different PR & now there's a conflict). So please remove that commit from this with git rebase -i master. Reviewers can't easily test building this until that's fixed.

pkgs/applications/networking/mailreaders/mailspring/default.nix

pkgs/top-level/all-packages.nix

toschmidt · 2020-04-29T10:53:13Z

@drewrisinger thanks for your review.

Also, when trying to review this, I ran into a merge conflict with the maintainers list (probably b/c you submitted a different PR & now there's a conflict). So please remove that commit from this with git rebase -i master. Reviewers can't easily test building this until that's fixed.

I removed myself from the maintainer list (it's my only PR so there should not be any conflict in that file). Before merging, we should probably revert that unless someone else wants to maintain the package. I also updated mailspring to the latest version (1.7.6) and applied your suggestions.

drewrisinger · 2020-04-29T14:44:14Z

Oh, sorry. If this is actually your first package, then a commit adding yourself as maintainer IS appropriate. Just make sure that it merges with master branch. I recommend rebasing, dropping the revert commit, and then git push -f that fixed branch. You should resolve whatever merge commit the maintainer list pops up.

Builds locally with nixpkgs-review pr 85492

https://github.com/NixOS/nixpkgs/pull/85492
1 package built:
mailspring

drewrisinger · 2020-04-29T14:45:04Z

Note: commits will also need squashed down to just the maintainer commit & mailspring: init at 1.7.6 (PR title should also be changed) before this PR is accepted/merged.

toschmidt · 2020-04-29T15:07:46Z

Ok, the PR should have no conflicts with master and I squashed all commits down.

pkgs/applications/networking/mailreaders/mailspring/default.nix

drewrisinger

Few small notes still to be resolved by someone who knows more about packaging .deb better than I.

Builds locally, not tested.
nixpkgs-review pr 85492

https://github.com/NixOS/nixpkgs/pull/85492
1 package built:
mailspring

drewrisinger · 2020-05-04T18:24:59Z

Closes #69027

drewrisinger · 2020-05-04T18:26:02Z

Closes #69384

tyrion · 2020-05-29T19:57:15Z

I tried upgrading this to the latest Mailspring release and it seems to work fine so far.
You just need to change the version and sha checksum:

  version = "1.7.8";

  src = fetchurl {
    url = "https://github.com/Foundry376/Mailspring/releases/download/${version}/mailspring-${version}-amd64.deb";
    sha256 = "207fbf813b6da018a5b848e5dc1194b5996daab39adbd873b2cecb0565c105ce";
  };

pkgs/applications/networking/mailreaders/mailspring/default.nix

drewrisinger

Diff LGTM
Builds Locally
After build, GUI launches
Still not sure about best method when using dpkg, but seems to build fine.

nixos-discourse · 2020-06-09T20:34:29Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/181

tobkratz

I can get it work.
LGTM

nixos-discourse · 2020-06-24T14:00:54Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/172

nixos-discourse · 2020-07-07T12:13:12Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/181

danieldk

Thanks for submitting this and sorry for having to wait so long for getting this merged. It seems that mailspring relies on wget for crash dumps:

$ wrapit --bind /tmp/.X11-unix/X0 /tmp/.X11-unix/X0 --dir /home/daniel --setenv DISPLAY :0 `realpath results/mailspring/bin/mailspring`
Fontconfig error: Cannot load default config file
Running database migrations
App load time: 145ms

Running Setup
{"error":null}
Cannot upload crash dump: cannot exec /usr/bin/wget
Failed to get crash dump id.
Report Id: 
Cannot upload crash dump: cannot exec /usr/bin/wget
Failed to get crash dump id.
Report Id:

Could be something to fix for a future PR.

toschmidt force-pushed the mailspring branch from effb274 to 363d483 Compare April 18, 2020 11:55

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 18, 2020

drewrisinger suggested changes Apr 28, 2020

View reviewed changes

ofborg bot added the 2.status: merge conflict label Apr 29, 2020

toschmidt force-pushed the mailspring branch from 5223172 to 05b1866 Compare April 29, 2020 10:14

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 2.status: merge conflict 10.rebuild-darwin: 0 labels Apr 29, 2020

toschmidt force-pushed the mailspring branch from 05b1866 to 5e037ba Compare April 29, 2020 10:48

maintainers: add toschmidt

677df72

toschmidt force-pushed the mailspring branch from 5e037ba to 56803b8 Compare April 29, 2020 14:51

toschmidt changed the title ~~mailspring: init at 1.7.5~~ mailspring: init at 1.7.6 Apr 29, 2020

drewrisinger reviewed Apr 29, 2020

View reviewed changes

pkgs/applications/networking/mailreaders/mailspring/default.nix Show resolved Hide resolved

drewrisinger reviewed Apr 29, 2020

View reviewed changes

tyrion suggested changes May 29, 2020

View reviewed changes

pkgs/applications/networking/mailreaders/mailspring/default.nix Outdated Show resolved Hide resolved

toschmidt force-pushed the mailspring branch from 56803b8 to 1aaa479 Compare June 4, 2020 09:09

toschmidt changed the title ~~mailspring: init at 1.7.6~~ mailspring: init at 1.7.8 Jun 4, 2020

mailspring: init at 1.7.8

939f72a

toschmidt force-pushed the mailspring branch from 1aaa479 to 939f72a Compare June 4, 2020 09:12

drewrisinger approved these changes Jun 4, 2020

View reviewed changes

This was referenced Jun 18, 2020

mailspring: init at 1.6.3 #69384

Closed

Add mailspring #69027

Closed

tobkratz approved these changes Jun 18, 2020

View reviewed changes

danieldk approved these changes Jul 7, 2020

View reviewed changes

danieldk merged commit e01b23f into NixOS:master Jul 7, 2020

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mailspring: init at 1.7.8 #85492

mailspring: init at 1.7.8 #85492

toschmidt commented Apr 18, 2020 •

edited

drewrisinger commented Apr 28, 2020

drewrisinger left a comment

toschmidt commented Apr 29, 2020

drewrisinger commented Apr 29, 2020

drewrisinger commented Apr 29, 2020

toschmidt commented Apr 29, 2020

drewrisinger left a comment

drewrisinger commented May 4, 2020

drewrisinger commented May 4, 2020

tyrion commented May 29, 2020

drewrisinger left a comment

nixos-discourse commented Jun 9, 2020

tobkratz left a comment •

edited

nixos-discourse commented Jun 24, 2020

nixos-discourse commented Jul 7, 2020

danieldk left a comment

mailspring: init at 1.7.8 #85492

mailspring: init at 1.7.8 #85492

Conversation

toschmidt commented Apr 18, 2020 • edited

Motivation for this change

Things done

Notify maintainers

drewrisinger commented Apr 28, 2020

drewrisinger left a comment

Choose a reason for hiding this comment

toschmidt commented Apr 29, 2020

drewrisinger commented Apr 29, 2020

drewrisinger commented Apr 29, 2020

toschmidt commented Apr 29, 2020

drewrisinger left a comment

Choose a reason for hiding this comment

drewrisinger commented May 4, 2020

drewrisinger commented May 4, 2020

tyrion commented May 29, 2020

drewrisinger left a comment

Choose a reason for hiding this comment

nixos-discourse commented Jun 9, 2020

tobkratz left a comment • edited

Choose a reason for hiding this comment

nixos-discourse commented Jun 24, 2020

nixos-discourse commented Jul 7, 2020

danieldk left a comment

Choose a reason for hiding this comment

toschmidt commented Apr 18, 2020 •

edited

tobkratz left a comment •

edited