Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: per RFC45, remove more unquoted URLs #85493

Merged
merged 1 commit into from Apr 18, 2020
Merged

treewide: per RFC45, remove more unquoted URLs #85493

merged 1 commit into from Apr 18, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Apr 18, 2020 •
edited

Motivation for this change

This PR deals with the rest of the unquoted URLs in the tree.

I also included occurrences in comments and documentation just to be consistent.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

7c6f434c commented Apr 18, 2020 •
edited

@ofborg build tests.nixos-functions.nixos-test

cdepillabout
cdepillabout reviewed Apr 18, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-tensorflow.nix
Comment on lines +58 to +63
url = "https://github.com/haskell-suite/haskell-src-exts/commit/258e072fe9e37f94360b7488b58ea2832843bbb8.patch";
sha256 = "0ja6ai41v9plinlhjwja282m6ahn6mw4xi79np0jxqk83cg0z1ff";
})
# Adapt to MonadFail proposal (enables building on GHC >= 8.8)
(pkgs.fetchpatch {
url = https://gist.githubusercontent.com/mikesperber/0f2addaf3fbe97ffb4a5234d8711ba41/raw/e09e20998283c7195e82d546ba9266d290eb000d/gistfile1.txt;
url = "https://gist.githubusercontent.com/mikesperber/0f2addaf3fbe97ffb4a5234d8711ba41/raw/e09e20998283c7195e82d546ba9266d290eb000d/gistfile1.txt";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry, I let these through just recently.

cc @mikesperber as well

@7c6f434c 7c6f434c merged commit 6c0bacc into NixOS:master Apr 18, 2020
@prusnak prusnak deleted the rfc45 branch April 18, 2020 16:16
@prusnak
Copy link
Member Author

prusnak commented Apr 18, 2020

Thanks for the quick merge. AFAIK there are no unquoted URLs in the whole nixpkgs tree now.

@mikesperber
Copy link
Contributor

@cdepillabout Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

@7c6f434c 7c6f434c 7c6f434c approved these changes

@alyssais alyssais Awaiting requested review from alyssais alyssais is a code owner

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: haskell 6.topic: nixos 6.topic: python 6.topic: ruby 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prusnak @7c6f434c @mikesperber @cdepillabout