Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jalv: revert to gtk2 cause gtk3 wasn't showing the GUIs #85497

Merged
merged 1 commit into from Aug 8, 2020
Merged

jalv: revert to gtk2 cause gtk3 wasn't showing the GUIs #85497

merged 1 commit into from Aug 8, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Apr 18, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cillianderoiste April 18, 2020 14:56
@worldofpeace
Copy link
Contributor

worldofpeace commented Apr 19, 2020 •
edited

This has had a gtk3 ui since 1.2.0 according to the NEWS file https://gitlab.com/drobilla/jalv/-/blob/master/NEWS#L114. Can you share a screenshot or more info? We certainly don't want to revert to gtk2 as a solution.

@magnetophon
Copy link
Member Author

Sure, the program has the functionality, it just doesn't work on NixOS.
When you open a plugin in the gtk3 version, you get the generated generic gui instead of the gui that comes with the plugin.
Is that clear enough?

@magnetophon magnetophon mentioned this pull request Aug 8, 2020
Merged
10 tasks
@danieldk danieldk merged commit 1a0abf7 into NixOS:master Aug 8, 2020
@magnetophon
Copy link
Member Author

@danieldk Dank je wel! :)

@magnetophon magnetophon deleted the jalv branch August 8, 2020 16:08
@vcunat
Copy link
Member

vcunat commented Aug 8, 2020 •
edited

It was pushed by me (and signed). It's just GitHub getting this confused sometimes ;-)

I reported the bug to their support years ago, but apparently it doesn't feel important.

@danieldk
Copy link
Contributor

danieldk commented Aug 8, 2020

@vcunat thanks, felt like I had a blackout ;).

@magnetophon
Copy link
Member Author

@vcunat Thank you then! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@magnetophon @worldofpeace @vcunat @danieldk