Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages: unbreak typerep-map, co-log and co-log-sys #85486

Closed
wants to merge 0 commits into from
Closed

haskellPackages: unbreak typerep-map, co-log and co-log-sys #85486

wants to merge 0 commits into from

Conversation

poscat0x04
Copy link
Contributor

Motivation for this change

Fix broken packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@poscat0x04
Copy link
Contributor Author

poscat0x04 commented Apr 18, 2020 •
edited

by the way, unbreaking by disabling tests is very mechanical and can be easily automated

cdepillabout
cdepillabout reviewed Apr 18, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix Outdated
# Test suits dependencies are outdated
typerep-map = dontCheck super.typerep-map;

# Test suites are not implemented
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this comment mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typerep-map's test suite failed because dependencies could not be satisfied (QuichCheck etc. are out-dated)
co-log-sys's test suite failed because it uses IO while also enables NoImplicitPrelude.

cdepillabout
cdepillabout reviewed Apr 18, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix Outdated
# Test suite's dependencies (QuickCheck etc.) are outdated
typerep-map = dontCheck super.typerep-map;

# Test suite is broken (uses IO while enables NoImplicitPrelude at the same time)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you report this problem upstream, and then link to it in this comment here in the code?

We'd like to easily be able to know when we can remove these types of overrides.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure serokell/co-log-sys#5 kowainik/typerep-map#81

vrom911
vrom911 reviewed Apr 18, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-common.nix Outdated
@@ -1507,6 +1507,14 @@ self: super: {
# Fixed at head, but hasn't cut a release in awhile.
darcs = doJailbreak super.darcs;

# Test suite's dependencies (QuickCheck etc.) are outdated
# see https://github.com/kowainik/typerep-map/issues/81
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was resolved. New typerep-map-0.3.3.0 has been released on Hackage.

chshersh
chshersh reviewed Apr 18, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-hackage2nix.yaml Outdated
@@ -3637,8 +3637,6 @@ broken-packages:
- cmt
- cmv
- cnc-spec-compiler
- co-log
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, newer updated versions of co-log-core and co-log are released to Hackage:

@peti peti force-pushed the haskell-updates branch 4 times, most recently from 50d38e7 to e567a3b Compare April 24, 2020 20:13
@peti peti changed the base branch from haskell-updates to master May 1, 2020 18:21
@peti peti changed the base branch from master to haskell-updates May 1, 2020 18:21
@peti peti force-pushed the haskell-updates branch 4 times, most recently from d8e9519 to 1d4449c Compare May 1, 2020 19:52
@cdepillabout
Copy link
Member

@poscat0x04 What's the status of this? Can it be closed, or are you still working on it?

@poscat0x04 poscat0x04 closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

@chshersh chshersh chshersh left review comments

@vrom911 vrom911 vrom911 left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: haskell 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@poscat0x04 @cdepillabout @chshersh @vrom911