Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hydrogen-unstable: init at 1.0.0-beta2 #85454

Merged
merged 1 commit into from Apr 20, 2020
Merged

hydrogen-unstable: init at 1.0.0-beta2 #85454

merged 1 commit into from Apr 20, 2020

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Apr 17, 2020

Motivation for this change

hydrogen has infrequent releases (the last stable was in 2016).

This version switches from Qt 4 to Qt 5 (#33248).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cillianderoiste April 17, 2020 18:33
@magnetophon
Copy link
Member

When I build this with nix-review pr 85454 and run it with ./results/hydrogen-unstable/bin/hydrogen, I get:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)

@orivej
Copy link
Contributor Author

orivej commented Apr 20, 2020

I have just added wrapQtAppsHook to fix that.

@magnetophon
Copy link
Member

That was quick! :)
Builds and runs!

@orivej
Copy link
Contributor Author

orivej commented Apr 20, 2020 •
edited

This release does not contain GMkit (the old default drum kit), so it can't play old projects that use it until you install GMkit yourself. (There does not seem to be an automatic migration to the new default GMRockKit.) GMkit can be extracted from the old archive and saved in ~/.hydrogen/data/drumkits/GMkit

@orivej-nixos orivej-nixos merged commit f9fbc9b into NixOS:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @magnetophon @orivej-nixos