Skip to content
This repository has been archived by the owner on Jun 12, 2023. It is now read-only.

Add: first version of binaries-redirect #1

Merged
merged 1 commit into from Apr 18, 2020

Conversation

TrueBrain
Copy link
Member

It redirects four URLs that we know of are being used in the wild.
There are three URLs that are also known, but not handled:

/bananas -> handled via AWS on an earlier level
/nightlies -> the URL-schema changed, and the nightlies on
binaries.openttd are over a year old now
/custom -> those are no longer supported

These will return 404 if they hit this webserver.

It redirects four URLs that we know of are being used in the wild.
There are three URLs that are also known, but not handled:

  /bananas -> handled via AWS on an earlier level
  /nightlies -> the URL-schema changed, and the nightlies on
                binaries.openttd are over a year old now
  /custom -> those are no longer supported

These will return 404 if they hit this webserver.
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think a whole docker container just for an nginx vhost is a bit much, but ¯\_(ツ)_/¯

LABEL org.label-schema.build-date=${BUILD_DATE}
LABEL org.label-schema.version=${BUILD_VERSION}

RUN sed -i 's/access_log/# access_log/g' /etc/nginx/nginx.conf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN sed -i 's/access_log/# access_log/g' /etc/nginx/nginx.conf
RUN sed -i 's/^access_log/# access_log/g' /etc/nginx/nginx.conf

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, no. If I remember correctly, there can be spaces / tabs before this line. And depending on the version, this can change. So your suggestion might break it :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN sed -i 's/access_log/# access_log/g' /etc/nginx/nginx.conf
RUN sed -i 's/^\s*access_log/# access_log/g' /etc/nginx/nginx.conf

:p

@TrueBrain
Copy link
Member Author

Yes. The whole reason this docker is needed, is because AWS ALB cannot do it. Which sucks balls. But .. it does solve a lot of other problems, so I guess it is worth it. But if possible, I would have avoided it for sure :)

@TrueBrain TrueBrain merged commit 2e16564 into OpenTTD:master Apr 18, 2020
@TrueBrain TrueBrain deleted the first_version branch April 18, 2020 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants