-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
castor: init at 0.8.14 #85442
castor: init at 0.8.14 #85442
Conversation
12f6dc1
to
9e42ff5
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/159 |
a3b942b
to
c8cdcdb
Compare
If you click through to some of the packages in that table, you can see that it's actually picked up a mixture of castor the browser and castor the java library. I think the policy in nixpkgs is probably first come first serve, so as the first castor package, this would get to be called simply "castor". There's no guarantee that the other castor will ever be in nixpkgs either. |
I built this and ran the binary. I tested it by visiting some gemini and gopher sites and clicking around. It's not the most polished of clients at this stage (for me it shows most text as black on a dark background and it panics if you click an https link or an image link). However, I don't think that's got anything to do with how its packaged, so assuming it is useful to somebody and continues to improve, looks ok to me. |
Motivation for this change
We didn't have a gemini client yet :)
I'm not sure whether I should change the name to
castor-browser
, since there's already a differentcastor
packaged by some distros: https://repology.org/project/castorI'm also not sure if this needs some gtk wrapping stuffwrappedThings done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)