Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

castor: init at 0.8.14 #85442

Merged
merged 1 commit into from Jun 18, 2020
Merged

castor: init at 0.8.14 #85442

merged 1 commit into from Jun 18, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Apr 17, 2020

Motivation for this change

We didn't have a gemini client yet :)

I'm not sure whether I should change the name to castor-browser, since there's already a different castor packaged by some distros: https://repology.org/project/castor

I'm also not sure if this needs some gtk wrapping stuff wrapped

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fgaz fgaz force-pushed the castor/init branch 3 times, most recently from 12f6dc1 to 9e42ff5 Compare April 23, 2020 09:13
@fgaz fgaz changed the title castor: init at 0.5.0 castor: init at 0.7.0 Apr 23, 2020
@fgaz fgaz changed the title castor: init at 0.7.0 castor: init at 0.8.0 May 7, 2020
@fgaz fgaz changed the title castor: init at 0.8.0 castor: init at 0.8.5 May 14, 2020
@fgaz fgaz changed the title castor: init at 0.8.5 castor: init at 0.8.6 May 14, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/159

@fgaz fgaz force-pushed the castor/init branch 2 times, most recently from a3b942b to c8cdcdb Compare May 19, 2020 08:31
@fgaz fgaz changed the title castor: init at 0.8.6 castor: init at 0.8.8 May 19, 2020
@fgaz fgaz changed the title castor: init at 0.8.8 castor: init at 0.8.14 Jun 9, 2020
@fgaz fgaz mentioned this pull request Jun 16, 2020
10 tasks
@Thra11
Copy link
Member

Thra11 commented Jun 16, 2020

I'm not sure whether I should change the name to castor-browser, since there's already a different castor packaged by some distros: https://repology.org/project/castor

If you click through to some of the packages in that table, you can see that it's actually picked up a mixture of castor the browser and castor the java library. I think the policy in nixpkgs is probably first come first serve, so as the first castor package, this would get to be called simply "castor". There's no guarantee that the other castor will ever be in nixpkgs either.

@Thra11
Copy link
Member

Thra11 commented Jun 17, 2020

I built this and ran the binary. I tested it by visiting some gemini and gopher sites and clicking around.

It's not the most polished of clients at this stage (for me it shows most text as black on a dark background and it panics if you click an https link or an image link). However, I don't think that's got anything to do with how its packaged, so assuming it is useful to somebody and continues to improve, looks ok to me.

@ehmry ehmry merged commit 07299ff into NixOS:master Jun 18, 2020
@fgaz fgaz deleted the castor/init branch June 16, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants