st: copy config file in 'prePatch' instead of 'preBuild' #85443
Conversation
The patch phase runs after the build phase. Which means than when using an override to override both 'conf' and 'patches' to provide a custom config file and apply some patches, it doesn't work: - first the patches applied (optionally changing config.def.h) - then preBuild is run which overrides config.def.h with the user supplied one (effectively cancelling previously applied patches) By copying the config file in the prePatch phase instead, changes are kept and applied in order.
|
@GrahamcOfBorg build st |
|
Backport to 20.03: Auto-merging pkgs/applications/misc/st/default.nix |
ofborg
bot
added
10.rebuild-darwin: 0
|
I'm not quite sure about this changes, but I think it is breaking with common usage. I would guess that most users are adding some provided patches from upstream and a custom configuration file. By default, the patches were written against the vanilla release version. Thus, by applying the patches first, they should work. The custom configuration file will then just replace the (potentially patched) config file. However, if the custom configuration is applied at first, some patches are not compatible anymore because they are also adjusting the configuration file. This obviously fails, because it is no longer in its vanilla state. Furthermore, I think the argumentation is wrong. Afaik, the patch phase is run before the build phase, not afterwards. The explained state in the commit message was already there before. Would it be possible to revert this change? |
|
you can make a pr. |
The patch phase runs after the build phase. Which means than when
using an override to override both 'conf' and 'patches' to provide
a custom config file and apply some patches, it doesn't work:
supplied one (effectively cancelling previously applied patches)
By copying the config file in the prePatch phase instead, changes
are kept and applied in order.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)