nixos/services/samba: install samba when nixos module is enabled #85464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneeshusa
approved these changes
Apr 21, 2020
|
This should probably use |
loewenheim
force-pushed
the
install_samba
branch
from
7642567
to
4a66a7d
Compare
loewenheim
force-pushed
the
install_samba
branch
from
4a66a7d
to
2ccfcb1
Compare
loewenheim
force-pushed
the
install_samba
branch
from
2ccfcb1
to
9952763
Compare
|
@GrahamcOfBorg eval @GrahamcOfBorg test samba |
|
This also needs to be squashed and the commit message changed to the format specified in https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md |
loewenheim
force-pushed
the
install_samba
branch
from
9952763
to
b619f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It’s confusing that when I set
services.samba.enabled = true;inconfiguration.nixI can’t use samba becausesmbpasswdis not (straightforwardly) accessible.This fix was suggested in #22435.