Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add myself (wamserma) to maintainer list #85466

Merged
merged 1 commit into from Apr 18, 2020

Conversation

wamserma
Copy link
Member

Motivation for this change

There are multiple PRs open where I listed myself as maintainer. Adding myself to the list with a dedicated PR will eventually let these PRs pass the CI tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Signed-off-by: Markus S. Wamser <github-dev@mail2013.wamser.eu>
@veprbl veprbl merged commit 7bac5db into NixOS:master Apr 18, 2020
@wamserma wamserma deleted the add-wamserma-maintainers branch April 18, 2020 07:07
This was referenced Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants