Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next-gtk-webkit: init at 1.5.0 #85465

Closed
wants to merge 1 commit into from
Closed

next-gtk-webkit: init at 1.5.0 #85465

wants to merge 1 commit into from

Conversation

bqv
Copy link
Contributor

@bqv bqv commented Apr 17, 2020

Motivation for this change

Break off next-gtk-webkit into it's own package, so builds happen and it can be overriden nicely.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Hmm, not sure how I feel about this. I believe I refactored this package and next-gtk-webkit was exposed, but I made it private seemingly without qualms and good justification. Can't recall exactly though.

@bqv
Copy link
Contributor Author

bqv commented Apr 18, 2020

The alternative I see is to move all inputs from next-gtk-webkit to next so it can be nicely overridden, but I can't see any obvious issues with this

@bqv
Copy link
Contributor Author

bqv commented Apr 18, 2020

(Thinking something along the lines of 829f41459f2a1d4ef81c0627f761959c5da4bcab)

@bqv bqv mentioned this pull request Apr 19, 2020
Closed
@bqv
Copy link
Contributor Author

bqv commented Apr 19, 2020

Hmm, seems next-gtk-webkit is about to die (see atlas-engineer/nyxt#422 (comment)), this can go away :)

@bqv bqv closed this Apr 19, 2020
@bqv bqv deleted the next-gtk-webkit branch April 19, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bqv @worldofpeace