Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luajit_2_0, luajit_2_1: bump to 2020-03-20, GC64 mode switch #85483

Merged
merged 1 commit into from May 1, 2020
Merged

luajit_2_0, luajit_2_1: bump to 2020-03-20, GC64 mode switch #85483

merged 1 commit into from May 1, 2020

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Apr 18, 2020

Motivation for this change

Follows "the plan": #77800 (comment)

  • update luajit_2_1 to latest 2.1 branch and build it with -DLUAJIT_DISABLE_GC64 by default
  • add flag in luajit_2_1 package E.g. gc64 so packages like Minetest can use LJ_GC64 variant easily

LuaJIT didn't release for a long time, there are lots of stability fixes (especially for aarch64) and GC64 mode (no more memory limit on first 2G of process space) is finally usable for production but still disabled by default, it can be turned on by new enableGC64 flag.

Heavy LuaJIT consumers like OpenResty are using latest git versions for stability and performance. It should be safe to use them for default LuaJIT interpreter.

Should solve #77800

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @vcunat

@ofborg ofborg bot added the 6.topic: lua label Apr 18, 2020
vcunat
vcunat requested changes Apr 26, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, if the comments get fixed. I could do that myself, but I want to wait for (your) feedback anyway before merging that.

I checked x86_64 and aarch64 a little, by building knot-resolver the three combinations (2.0 doesn't support aarch64; tests run luajit stuff inside).

pkgs/development/interpreters/luajit/default.nix Outdated Show resolved Hide resolved
pkgs/development/interpreters/luajit/2.1.nix Outdated Show resolved Hide resolved
pkgs/development/interpreters/luajit/2.0.nix Outdated Show resolved Hide resolved
@vcunat vcunat mentioned this pull request Apr 26, 2020
Closed
10 tasks
@ofborg ofborg bot requested a review from vcunat April 27, 2020 07:49
@vcunat vcunat merged commit b9f359b into NixOS:master May 1, 2020
@lblasc lblasc deleted the luajit-2020-03-20 branch May 1, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@grwlf grwlf Awaiting requested review from grwlf

@andir andir Awaiting requested review from andir

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lblasc @vcunat