Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

age: 1.0.0-beta2 -> git-2020-03-25 #85482

Merged
merged 1 commit into from Apr 20, 2020
Merged

age: 1.0.0-beta2 -> git-2020-03-25 #85482

merged 1 commit into from Apr 20, 2020

Conversation

L-as
Copy link
Member

@L-as L-as commented Apr 18, 2020

There has been no new official release of age, but some important fixes and changes have been done since the last release in December: FiloSottile/age@v1.0.0-beta2...f0f8092

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from tazjin and kalbasit April 18, 2020 07:23
tazjin
tazjin reviewed Apr 18, 2020
View reviewed changes
pkgs/tools/security/age/default.nix Outdated
@@ -2,9 +2,9 @@

buildGoModule rec {
pname = "age";
version = "1.0.0-beta2";
version = "2020-03-25";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include a master- or similar prefix here to make it clearer what version this is, otherwise LGTM.

@tazjin
Copy link
Member

tazjin commented Apr 18, 2020

@FiloSottile Are you planning to cut a beta3 or similar at any point?

@L-as
Copy link
Member Author

L-as commented Apr 18, 2020

It's now called master-2020-03-25

@alyssais
Copy link
Member

It's now called master-2020-03-25

Manual says:

If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".

(Sorry)

@ofborg ofborg bot requested a review from tazjin April 18, 2020 13:56
@L-as
age: 1.0.0-beta2 -> unstable-2020-03-25
8a5fa65 
There has been no new official release of age,
but some important fixes and changes have been
done since the last release in December:
FiloSottile/age@v1.0.0-beta2...f0f8092
@L-as
Copy link
Member Author

L-as commented Apr 18, 2020

That ought to be in CONTRIBUTING.md

@alyssais
Copy link
Member

CONTRIBUTING.md should probably just link to the manual section on package naming so we don’t have to keep both in sync.

leahneukirchen
leahneukirchen approved these changes Apr 19, 2020
View reviewed changes
Copy link
Contributor

@leahneukirchen leahneukirchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that data can be encrypted/decrypted with both versions in both directions.

@tazjin
Copy link
Member

tazjin commented Apr 19, 2020

Thanks @leahneukirchen!

tazjin
tazjin approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@tazjin tazjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mic92 Mic92 merged commit 32029f3 into NixOS:master Apr 20, 2020
@L-as L-as deleted the patch-1 branch May 5, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahneukirchen leahneukirchen leahneukirchen approved these changes

@tazjin tazjin tazjin approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@L-as @tazjin @alyssais @leahneukirchen @Mic92