Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kibi: init at 0.2.0 #85852

Merged
merged 1 commit into from Aug 27, 2020
Merged

kibi: init at 0.2.0 #85852

merged 1 commit into from Aug 27, 2020

Conversation

robertodr
Copy link
Contributor

Things done

Added the kibi editor

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

drewrisinger
drewrisinger approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few formatting fixes, otherwise diff LGTM

Builds fine via nixpkgs-review pr 85852

https://github.com/NixOS/nixpkgs/pull/85852
1 package built:
kibi

pkgs/applications/editors/kibi/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/kibi/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build kibi

drewrisinger
drewrisinger suggested changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds locally.
Commits need squashed before merging.

nixpkgs-review pr 85852

https://github.com/NixOS/nixpkgs/pull/85852
1 package built:
kibi

@robertodr robertodr changed the title kibi: init at 0.1.2 kibi: init at 0.2.0 Apr 29, 2020
@robertodr
Copy link
Contributor Author

Version 0.2.0 was released in the meantime.

@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build kibi

drewrisinger
drewrisinger approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine locally & via OfBorg. Commits are fixed up.

@Lassulus Lassulus merged commit 1c2ebdc into NixOS:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robertodr @drewrisinger @Lassulus