New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3: Add "--py3" to taskcluster-run.py #23182
Conversation
Ahem, sorry. I may have gotten this confused; is this for a trigger branch run or for running |
This is for adding a trigger run of Python 3 on triggers/chrome_dev and triggers/firefox_nightly (item 2 mentioned in your email) |
Pushed @ziransun - do I understand correctly that there's no point pushing to |
https://community-tc.services.mozilla.com/tasks/groups/TriD1MleTcOj7RNYgKFZaA should be the TaskCluster URL for the |
Yes. |
Looks like it failed very quickly? One of the logs has:
|
Looks that we need to install python3-distutils. |
I wonder what happens if we escape manifest download and only do wpt run with python 3 |
If you look further in the log, I think we hit the same problem. It actually continues even though the manifest call failed! |
Can we do "sudo apt-get install python3-distutils" in the linux machine that is running this task? |
@Hexcles is this the sort of thing that we would normally do in our Dockerfile, or somewhere else? For this temporary testing, I would also be happy to just install it somewhere hacky if that works. |
I think we should just add
|
Curious, how do we get |
Both |
…r image, a=testonly Automatic update from web-platform-tests Add python3 and python3-pip to the docker image (#23190) See web-platform-tests/wpt#23182 (comment) Update README too -- wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d wpt-pr: 23190
…r image, a=testonly Automatic update from web-platform-tests Add python3 and python3-pip to the docker image (#23190) See web-platform-tests/wpt#23182 (comment) Update README too -- wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d wpt-pr: 23190
…r image, a=testonly Automatic update from web-platform-tests Add python3 and python3-pip to the docker image (#23190) See web-platform-tests/wpt#23182 (comment) Update README too -- wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d wpt-pr: 23190 UltraBlame original commit: 30097d54120c471a294b468e4b3826495f978141
…r image, a=testonly Automatic update from web-platform-tests Add python3 and python3-pip to the docker image (#23190) See web-platform-tests/wpt#23182 (comment) Update README too -- wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d wpt-pr: 23190 UltraBlame original commit: e05963ca485f26fb7c5a70065324a45c0dede3f1
…r image, a=testonly Automatic update from web-platform-tests Add python3 and python3-pip to the docker image (#23190) See web-platform-tests/wpt#23182 (comment) Update README too -- wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d wpt-pr: 23190 UltraBlame original commit: 30097d54120c471a294b468e4b3826495f978141
…r image, a=testonly Automatic update from web-platform-tests Add python3 and python3-pip to the docker image (#23190) See web-platform-tests/wpt#23182 (comment) Update README too -- wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d wpt-pr: 23190 UltraBlame original commit: e05963ca485f26fb7c5a70065324a45c0dede3f1
…r image, a=testonly Automatic update from web-platform-tests Add python3 and python3-pip to the docker image (#23190) See web-platform-tests/wpt#23182 (comment) Update README too -- wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d wpt-pr: 23190 UltraBlame original commit: 30097d54120c471a294b468e4b3826495f978141
…r image, a=testonly Automatic update from web-platform-tests Add python3 and python3-pip to the docker image (#23190) See web-platform-tests/wpt#23182 (comment) Update README too -- wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d wpt-pr: 23190 UltraBlame original commit: e05963ca485f26fb7c5a70065324a45c0dede3f1
@stephenmcgruer: |
Happy to do so; can you rebase this PR to master to pick up the changes @Hexcles has made? I can then push the new SHA to the trigger branches. |
I have pushed d47787d (parent commit d929bed), to https://community-tc.services.mozilla.com/tasks/groups/V1c_ockSTQKTwgZTUyCdcQ should be the TaskCluster run for it. |
Thank you! |
I think https://wpt.fyi/results/?diff&filter=ADC&run_id=528790002&run_id=519310004 should be the diff. |
I have pushed 2ce3aa7 (parent commit 2990842), which is a cherry-pick of this change onto master, to https://community-tc.services.mozilla.com/tasks/groups/dc8GrlEaRAKicX-tr97Lgw should be the Taskcluster run for it. |
I believe https://wpt.fyi/results/?diff&filter=ADC&run_id=601030002&run_id=629830001 should be the diff |
@stephenmcgruer: Is it okay to trigger another run? The PRs that I mentioned during the meeting have now been merged in. Thank you! |
I have pushed 926a8ed (parent commit 7c7fe3f), which is a cherry-pick of this change onto master, to https://community-tc.services.mozilla.com/tasks/groups/eW7WDm5CQ36lcfl6pZfnFQ should be the Taskcluster run for it. |
I believe https://wpt.fyi/results/?diff&filter=ADC&run_id=632440001&run_id=619000003 is the diff for the two runs. Awkwardly, chrome_dev updated right in-between the two runs which has caused some churn in results -_-, so I'm going to wait until tomorrow and run another trigger run to get a cleaner comparison. |
I have pushed 038f8e8 (parent commit fd5a851), which is a cherry-pick of this change onto master, to https://community-tc.services.mozilla.com/tasks/groups/ZZUrTFXoRQS7DYRuQ1n65Q should be the Taskcluster run for it. |
@ziransun I have triggered a Firefox nightly run for 083393c, which is this CL rebased onto master and with a fix for #25012. https://wpt.fyi/results/?run_id=638560001&run_id=642320001&diff should be the wpt.fyi diff against its nearest parent, please take a look |
@stephenmcgruer: Thanks! I will check on this. |
Thank you @stephenmcgruer! I'll look into them. |
Closing this PR; we have switched the CI to Py3 and I think this particular experiment is not needed. |
No description provided.