Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3: Add "--py3" to taskcluster-run.py #23182

Closed
wants to merge 2 commits into from

Conversation

ziransun
Copy link
Member

No description provided.

@stephenmcgruer stephenmcgruer changed the title Python 3: Add "--py3" to taskcluster-run.py Python 3: Add "--py3" to taskcluster-run.py [Not For Review] Apr 22, 2020
@stephenmcgruer stephenmcgruer changed the title Python 3: Add "--py3" to taskcluster-run.py [Not For Review] Python 3: Add "--py3" to taskcluster-run.py Apr 22, 2020
@stephenmcgruer
Copy link
Contributor

Ahem, sorry. I may have gotten this confused; is this for a trigger branch run or for running infrastructure/ tests?

@ziransun
Copy link
Member Author

This is for adding a trigger run of Python 3 on triggers/chrome_dev and triggers/firefox_nightly (item 2 mentioned in your email)

@stephenmcgruer
Copy link
Contributor

Pushed 3effe467b657cb6a61b1cee55bd5cc5136f02a0a to triggers/chrome_dev. The closest SHA with a run on wpt.fyi is its grandparent, 9a6026305062c90d84a567d81434010dde6c6c22: https://wpt.fyi/results/?run_id=469690003

@ziransun - do I understand correctly that there's no point pushing to triggers/firefox_nightly yet, as Firefox does not yet work in py3?

@stephenmcgruer
Copy link
Contributor

https://community-tc.services.mozilla.com/tasks/groups/TriD1MleTcOj7RNYgKFZaA should be the TaskCluster URL for the triggers/chrome_dev run

@ziransun
Copy link
Member Author

@ziransun - do I understand correctly that there's no point pushing to triggers/firefox_nightly yet, as Firefox does not yet work in py3?

Yes.

@stephenmcgruer
Copy link
Contributor

Looks like it failed very quickly? One of the logs has:

2020-04-22 19:47:09,848 - tc-run - INFO - Downloading manifest in Python 3 environment
Traceback (most recent call last):
  File "./wpt", line 4, in <module>
    from tools.wpt import wpt
  File "/home/test/web-platform-tests/tools/wpt/wpt.py", line 10, in <module>
    from . import virtualenv
  File "/home/test/web-platform-tests/tools/wpt/virtualenv.py", line 5, in <module>
    from distutils.spawn import find_executable
ModuleNotFoundError: No module named 'distutils.spawn'

@ziransun
Copy link
Member Author

Looks that we need to install python3-distutils.

@ziransun
Copy link
Member Author

I wonder what happens if we escape manifest download and only do wpt run with python 3

@stephenmcgruer
Copy link
Contributor

I wonder what happens if we escape manifest download and only do wpt run with python 3

If you look further in the log, I think we hit the same problem. It actually continues even though the manifest call failed!

@ziransun
Copy link
Member Author

Can we do "sudo apt-get install python3-distutils" in the linux machine that is running this task?

@stephenmcgruer
Copy link
Contributor

Can we do "sudo apt-get install python3-distutils" in the linux machine that is running this task?

@Hexcles is this the sort of thing that we would normally do in our Dockerfile, or somewhere else? For this temporary testing, I would also be happy to just install it somewhere hacky if that works.

@Hexcles
Copy link
Member

Hexcles commented Apr 22, 2020

I think we should just add python3-pip to the base image, which is also required by tox and depends on python3-distutils.

@stephenmcgruer
Copy link
Contributor

Add python3 and python3-pip here:

Curious, how do we get python3 today? (Since it seems to be available in TC?)

@Hexcles
Copy link
Member

Hexcles commented Apr 22, 2020

Curious, how do we get python3 today? (Since it seems to be available in TC?)

Both python and python3 are included in the base ubuntu:18.04 image (so technically we don't need to list either in apt-get install, but it also doesn't hurt).

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 1, 2020
…r image, a=testonly

Automatic update from web-platform-tests
Add python3 and python3-pip to the docker image (#23190)

See
web-platform-tests/wpt#23182 (comment)

Update README too

--

wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d
wpt-pr: 23190
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request May 1, 2020
…r image, a=testonly

Automatic update from web-platform-tests
Add python3 and python3-pip to the docker image (#23190)

See
web-platform-tests/wpt#23182 (comment)

Update README too

--

wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d
wpt-pr: 23190
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request May 3, 2020
…r image, a=testonly

Automatic update from web-platform-tests
Add python3 and python3-pip to the docker image (#23190)

See
web-platform-tests/wpt#23182 (comment)

Update README too

--

wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d
wpt-pr: 23190

UltraBlame original commit: 30097d54120c471a294b468e4b3826495f978141
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request May 3, 2020
…r image, a=testonly

Automatic update from web-platform-tests
Add python3 and python3-pip to the docker image (#23190)

See
web-platform-tests/wpt#23182 (comment)

Update README too

--

wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d
wpt-pr: 23190

UltraBlame original commit: e05963ca485f26fb7c5a70065324a45c0dede3f1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request May 3, 2020
…r image, a=testonly

Automatic update from web-platform-tests
Add python3 and python3-pip to the docker image (#23190)

See
web-platform-tests/wpt#23182 (comment)

Update README too

--

wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d
wpt-pr: 23190

UltraBlame original commit: 30097d54120c471a294b468e4b3826495f978141
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request May 3, 2020
…r image, a=testonly

Automatic update from web-platform-tests
Add python3 and python3-pip to the docker image (#23190)

See
web-platform-tests/wpt#23182 (comment)

Update README too

--

wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d
wpt-pr: 23190

UltraBlame original commit: e05963ca485f26fb7c5a70065324a45c0dede3f1
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request May 3, 2020
…r image, a=testonly

Automatic update from web-platform-tests
Add python3 and python3-pip to the docker image (#23190)

See
web-platform-tests/wpt#23182 (comment)

Update README too

--

wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d
wpt-pr: 23190

UltraBlame original commit: 30097d54120c471a294b468e4b3826495f978141
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request May 3, 2020
…r image, a=testonly

Automatic update from web-platform-tests
Add python3 and python3-pip to the docker image (#23190)

See
web-platform-tests/wpt#23182 (comment)

Update README too

--

wpt-commits: cbb6f674bad9b7f58845d4b5fd5b232effea5f4d
wpt-pr: 23190

UltraBlame original commit: e05963ca485f26fb7c5a70065324a45c0dede3f1
@ziransun
Copy link
Member Author

ziransun commented May 8, 2020

@stephenmcgruer:
Does it make sense to trigger another run based on the wptserve changes made by @Hexcles? This will give me a better idea of failed tests in Python 3.

@stephenmcgruer
Copy link
Contributor

Happy to do so; can you rebase this PR to master to pick up the changes @Hexcles has made? I can then push the new SHA to the trigger branches.

@stephenmcgruer
Copy link
Contributor

I have pushed d47787d (parent commit d929bed), to triggers/chrome_dev.

https://community-tc.services.mozilla.com/tasks/groups/V1c_ockSTQKTwgZTUyCdcQ should be the TaskCluster run for it.

@ziransun
Copy link
Member Author

ziransun commented May 8, 2020

Thank you!

@stephenmcgruer
Copy link
Contributor

@stephenmcgruer
Copy link
Contributor

I have pushed 2ce3aa7 (parent commit 2990842), which is a cherry-pick of this change onto master, to triggers/chrome_dev.

https://community-tc.services.mozilla.com/tasks/groups/dc8GrlEaRAKicX-tr97Lgw should be the Taskcluster run for it.

@stephenmcgruer
Copy link
Contributor

@ziransun
Copy link
Member Author

@stephenmcgruer: Is it okay to trigger another run? The PRs that I mentioned during the meeting have now been merged in. Thank you!

@stephenmcgruer
Copy link
Contributor

I have pushed 926a8ed (parent commit 7c7fe3f), which is a cherry-pick of this change onto master, to triggers/chrome_dev.

https://community-tc.services.mozilla.com/tasks/groups/eW7WDm5CQ36lcfl6pZfnFQ should be the Taskcluster run for it.

@stephenmcgruer
Copy link
Contributor

I believe https://wpt.fyi/results/?diff&filter=ADC&run_id=632440001&run_id=619000003 is the diff for the two runs.

Awkwardly, chrome_dev updated right in-between the two runs which has caused some churn in results -_-, so I'm going to wait until tomorrow and run another trigger run to get a cleaner comparison.

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Jul 29, 2020

I have pushed 038f8e8 (parent commit fd5a851), which is a cherry-pick of this change onto master, to triggers/chrome_dev.

https://community-tc.services.mozilla.com/tasks/groups/ZZUrTFXoRQS7DYRuQ1n65Q should be the Taskcluster run for it.

@stephenmcgruer
Copy link
Contributor

@ziransun I have triggered a Firefox nightly run for 083393c, which is this CL rebased onto master and with a fix for #25012.

https://wpt.fyi/results/?run_id=638560001&run_id=642320001&diff should be the wpt.fyi diff against its nearest parent, please take a look

@ziransun
Copy link
Member Author

@ziransun I have triggered a Firefox nightly run for 083393c, which is this CL rebased onto master and with a fix for #25012.

https://wpt.fyi/results/?run_id=638560001&run_id=642320001&diff should be the wpt.fyi diff against its nearest parent, please take a look

@stephenmcgruer: Thanks! I will check on this.

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Oct 1, 2020

I have pushed 9d65b30 , which is a cherry-pick of this PR onto master, to both triggers/chrome_dev and triggers/firefox_nightly. The parent commit is 6ceb598 .

I will update with wpt.fyi URLs once the runs complete and have results processed.

@stephenmcgruer
Copy link
Contributor

Closing this PR; we have switched the CI to Py3 and I think this particular experiment is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants