Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnnl: rename to oneDNN to track upstream project rename #85839

Merged
merged 1 commit into from
May 6, 2020
Merged

dnnl: rename to oneDNN to track upstream project rename #85839

merged 1 commit into from
May 6, 2020
+6 −6

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Apr 23, 2020

See the link in the default.nix file for details. This adds an alias for
backwards compatibility.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@bhipple
dnnl: rename to oneDNN to track upstream project rename

Unverified

The email in this signature doesn’t match the committer email.
GPG key ID: B2D065AD4D6E0C81
Expired
Learn about vigilant mode
bab9dab 
See the link in the default.nix file for details.  This adds an alias for
backwards compatibility.
@bhipple
Copy link
Contributor Author

bhipple commented Apr 23, 2020 •
edited
Loading

@GrahamcOfBorg build oneDNN dnnl

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Apr 23, 2020
@ofborg ofborg bot requested a review from alexarice April 23, 2020 02:33
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 23, 2020
@bhipple
Copy link
Contributor Author

bhipple commented May 2, 2020

CC @markuskowa

@markuskowa
Copy link
Member

Depending on how widely used the libraray is, you could either make an entry in pkgs/top-level/aliases.nix or add a line to the release notes.

@bhipple
Copy link
Contributor Author

bhipple commented May 6, 2020

We have an alias here, so that should be fine.

@markuskowa markuskowa merged commit e231564 into NixOS:master May 6, 2020
@bhipple bhipple mentioned this pull request May 9, 2020
Merged
10 tasks
@bhipple bhipple deleted the u/dnnl-oneDNN branch June 2, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarice alexarice

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bhipple @markuskowa