New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not merge-if-green in case there is no accepted review #1

Open

acomodi opened this issue Apr 23, 2020 · 0 comments

acomodi commented Apr 23, 2020

The merge-if-green is a useful label in case reviews gets accepted and it is just a matter of waiting CI completion.

The downside is that, if the label is added by mistake, the PR could get merged without any accepted review.

There should be a check that tests that a PR labelled with merge-if-green has at least one accepted review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment