Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acl2: 8.2 -> 8.3 #85825

Merged
merged 1 commit into from Apr 24, 2020
Merged

acl2: 8.2 -> 8.3 #85825

merged 1 commit into from Apr 24, 2020

Conversation

kini
Copy link
Member

@kini kini commented Apr 22, 2020 •
edited

Motivation for this change

New upstream version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c April 23, 2020 00:07
@alyssais
Copy link
Member

Should either be fixed or marked broken or unsupported on aarch64-linux.

@kini
Copy link
Member Author

kini commented Apr 24, 2020

Thanks @alyssais. ACL2 isn't supposed to be fundamentally platform-specific or anything, so I guess "broken" is more appropriate than "unsupported" here (?). I've now marked it as broken on aarch64-linux specifically. I also changed the platforms list to "all", since it's supposed to run on Darwin as well, according to upstream. But it seems that ofborg doesn't test PRs on Darwin, and I don't have a Darwin machine to test on, either...

@7c6f434c
Copy link
Member

@ofborg build acl2

OfBorg can build on Darwin, but has a different access policy there.

@7c6f434c 7c6f434c merged commit e170e0e into NixOS:master Apr 24, 2020
@kini kini deleted the acl2-8.3 branch April 24, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kini @alyssais @7c6f434c