Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.azure*: bump, azure-cli: 2.2.0 -> 2.4.0 #85826

Merged
merged 21 commits into from
May 2, 2020
Merged

python3Packages.azure*: bump, azure-cli: 2.2.0 -> 2.4.0 #85826

merged 21 commits into from
May 2, 2020
+212 −105

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Apr 23, 2020 •
edited
Loading

Motivation for this change

bump azure python packages

bump azure-cli: 2.2.0 -> 2.4.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/85826
65 package marked as broken and skipped:
clang-sierraHack-stdenv crossLibcStdenv digitalbitbox glibcCross linuxPackages-libre.sch_cake linuxPackages_4_14.sch_cake linuxPackages_4_4.evdi linuxPackages_4_4.sysdig linuxPackages_4_9.sysdig linuxPackages_5_5.sch_cake linuxPackages_5_6.sch_cake linuxPackages_hardened.sch_cake linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 linuxPackages_hardkernel_4_14.nvidiabl linuxPackages_hardkernel_4_14.r8125 linuxPackages_hardkernel_4_14.r8168 linuxPackages_hardkernel_4_14.rtl8814au linuxPackages_hardkernel_4_14.rtl8821ce linuxPackages_hardkernel_4_14.rtlwifi_new linuxPackages_hardkernel_4_14.sch_cake linuxPackages_hardkernel_4_14.sysdig linuxPackages_hardkernel_4_14.v4l2loopback linuxPackages_hardkernel_4_14.vhba linuxPackages_hardkernel_4_14.virtualbox linuxPackages_hardkernel_4_14.virtualboxGuestAdditions linuxPackages_latest-libre.sch_cake linuxPackages_latest_hardened.sch_cake linuxPackages_latest_xen_dom0.sch_cake linuxPackages_latest_xen_dom0_hardened.sch_cake linuxPackages_testing_bcachefs.sch_cake linuxPackages_xen_dom0.sch_cake muslCross nix-linter ocamlPackages.stog octave-jit php73Extensions.zmq php74Extensions.couchbase php74Extensions.pthreads python27Packages.azure-identity python27Packages.azure-keyvault-certificates python27Packages.azure-mgmt-core python27Packages.caffe python27Packages.habanero python27Packages.handout python27Packages.hass-nabucasa python27Packages.libmodulemd python37Packages.nixpart python37Packages.notify python37Packages.pyblock python38Packages.azure-keyvault-certificates python38Packages.azure-mgmt-core python38Packages.azure-mgmt-redhatopenshift python38Packages.libselinux python38Packages.poezio python38Packages.pyblock qes synfigstudio telepathy-salut telepathy_salut

169 package built:
azure-cli nixops_1_6_1 python27Packages.azure-applicationinsights python27Packages.azure-batch python27Packages.azure-eventgrid python27Packages.azure-functions-devops-build python27Packages.azure-graphrbac python27Packages.azure-loganalytics python27Packages.azure-mgmt-advisor python27Packages.azure-mgmt-applicationinsights python27Packages.azure-mgmt-authorization python27Packages.azure-mgmt-batch python27Packages.azure-mgmt-batchai python27Packages.azure-mgmt-billing python27Packages.azure-mgmt-cdn python27Packages.azure-mgmt-cognitiveservices python27Packages.azure-mgmt-commerce python27Packages.azure-mgmt-common python27Packages.azure-mgmt-compute python27Packages.azure-mgmt-consumption python27Packages.azure-mgmt-containerinstance python27Packages.azure-mgmt-containerservice python27Packages.azure-mgmt-cosmosdb python27Packages.azure-mgmt-datafactory python27Packages.azure-mgmt-datalake-analytics python27Packages.azure-mgmt-datalake-store python27Packages.azure-mgmt-datamigration python27Packages.azure-mgmt-devspaces python27Packages.azure-mgmt-devtestlabs python27Packages.azure-mgmt-dns python27Packages.azure-mgmt-eventgrid python27Packages.azure-mgmt-eventhub python27Packages.azure-mgmt-hanaonazure python27Packages.azure-mgmt-iotcentral python27Packages.azure-mgmt-iothub python27Packages.azure-mgmt-iothubprovisioningservices python27Packages.azure-mgmt-keyvault python27Packages.azure-mgmt-loganalytics python27Packages.azure-mgmt-logic python27Packages.azure-mgmt-machinelearningcompute python27Packages.azure-mgmt-managementgroups python27Packages.azure-mgmt-managementpartner python27Packages.azure-mgmt-maps python27Packages.azure-mgmt-marketplaceordering python27Packages.azure-mgmt-media python27Packages.azure-mgmt-monitor python27Packages.azure-mgmt-msi python27Packages.azure-mgmt-network python27Packages.azure-mgmt-notificationhubs python27Packages.azure-mgmt-policyinsights python27Packages.azure-mgmt-powerbiembedded python27Packages.azure-mgmt-rdbms python27Packages.azure-mgmt-recoveryservices python27Packages.azure-mgmt-recoveryservicesbackup python27Packages.azure-mgmt-redis python27Packages.azure-mgmt-relay python27Packages.azure-mgmt-reservations python27Packages.azure-mgmt-resource python27Packages.azure-mgmt-scheduler python27Packages.azure-mgmt-search python27Packages.azure-mgmt-servicebus python27Packages.azure-mgmt-servicefabric python27Packages.azure-mgmt-signalr python27Packages.azure-mgmt-sql python27Packages.azure-mgmt-storage python27Packages.azure-mgmt-subscription python27Packages.azure-mgmt-trafficmanager python27Packages.azure-mgmt-web python27Packages.azure-servicebus python27Packages.azure-servicefabric python27Packages.msrest python27Packages.msrestazure python27Packages.vsts python27Packages.vsts-cd-manager python37Packages.azure-applicationinsights python37Packages.azure-batch python37Packages.azure-core python37Packages.azure-eventgrid python37Packages.azure-functions-devops-build python37Packages.azure-graphrbac python37Packages.azure-identity python37Packages.azure-keyvault python37Packages.azure-keyvault-certificates python37Packages.azure-keyvault-keys python37Packages.azure-keyvault-secrets python37Packages.azure-loganalytics python37Packages.azure-mgmt-advisor python37Packages.azure-mgmt-apimanagement python37Packages.azure-mgmt-appconfiguration python37Packages.azure-mgmt-applicationinsights python37Packages.azure-mgmt-authorization python37Packages.azure-mgmt-batch python37Packages.azure-mgmt-batchai python37Packages.azure-mgmt-billing python37Packages.azure-mgmt-botservice python37Packages.azure-mgmt-cdn python37Packages.azure-mgmt-cognitiveservices python37Packages.azure-mgmt-commerce python37Packages.azure-mgmt-common python37Packages.azure-mgmt-compute python37Packages.azure-mgmt-consumption python37Packages.azure-mgmt-containerinstance python37Packages.azure-mgmt-containerregistry python37Packages.azure-mgmt-containerservice python37Packages.azure-mgmt-core python37Packages.azure-mgmt-cosmosdb python37Packages.azure-mgmt-datafactory python37Packages.azure-mgmt-datalake-analytics python37Packages.azure-mgmt-datalake-store python37Packages.azure-mgmt-datamigration python37Packages.azure-mgmt-deploymentmanager python37Packages.azure-mgmt-devspaces python37Packages.azure-mgmt-devtestlabs python37Packages.azure-mgmt-dns python37Packages.azure-mgmt-eventgrid python37Packages.azure-mgmt-eventhub python37Packages.azure-mgmt-hanaonazure python37Packages.azure-mgmt-hdinsight python37Packages.azure-mgmt-imagebuilder python37Packages.azure-mgmt-iotcentral python37Packages.azure-mgmt-iothub python37Packages.azure-mgmt-iothubprovisioningservices python37Packages.azure-mgmt-keyvault python37Packages.azure-mgmt-kusto python37Packages.azure-mgmt-loganalytics python37Packages.azure-mgmt-logic python37Packages.azure-mgmt-machinelearningcompute python37Packages.azure-mgmt-managedservices python37Packages.azure-mgmt-managementgroups python37Packages.azure-mgmt-managementpartner python37Packages.azure-mgmt-maps python37Packages.azure-mgmt-marketplaceordering python37Packages.azure-mgmt-media python37Packages.azure-mgmt-monitor python37Packages.azure-mgmt-msi python37Packages.azure-mgmt-netapp python37Packages.azure-mgmt-network python37Packages.azure-mgmt-notificationhubs python37Packages.azure-mgmt-policyinsights python37Packages.azure-mgmt-powerbiembedded python37Packages.azure-mgmt-privatedns python37Packages.azure-mgmt-rdbms python37Packages.azure-mgmt-recoveryservices python37Packages.azure-mgmt-recoveryservicesbackup python37Packages.azure-mgmt-redhatopenshift python37Packages.azure-mgmt-redis python37Packages.azure-mgmt-relay python37Packages.azure-mgmt-reservations python37Packages.azure-mgmt-resource python37Packages.azure-mgmt-scheduler python37Packages.azure-mgmt-search python37Packages.azure-mgmt-security python37Packages.azure-mgmt-servicebus python37Packages.azure-mgmt-servicefabric python37Packages.azure-mgmt-signalr python37Packages.azure-mgmt-sql python37Packages.azure-mgmt-sqlvirtualmachine python37Packages.azure-mgmt-storage python37Packages.azure-mgmt-subscription python37Packages.azure-mgmt-trafficmanager python37Packages.azure-mgmt-web python37Packages.azure-multiapi-storage python37Packages.azure-servicebus python37Packages.azure-servicefabric python37Packages.azure-storage-file-share python37Packages.msrest python37Packages.msrestazure python37Packages.vsts python37Packages.vsts-cd-manager

Sorry, something went wrong.

@jonringer jonringer requested a review from FRidh as a code owner April 23, 2020 00:03
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package labels Apr 23, 2020
@ofborg ofborg bot requested review from bendlas, kamadorueda and olcai April 23, 2020 00:10
@jonringer
Copy link
Contributor Author

apparently i need to add another package

@jonringer jonringer requested a review from colemickens April 23, 2020 00:30
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build azure-cli

drewrisinger
drewrisinger approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM minus minor misspelling in commit 0ecc611 (certificate misspelled), and minor comments.

Results of nixpkgs-review pr 85826 (didn't try broken packages):

https://github.com/NixOS/nixpkgs/pull/85826
5 package marked as broken and skipped:
fluidasserts python27Packages.azure python37Packages.azure python37Packages.fluidasserts python38Packages.azure

169 package built:
azure-cli nixops_1_6_1 python27Packages.azure-applicationinsights python27Packages.azure-batch python27Packages.azure-eventgrid python27Packages.azure-functions-devops-build python27Packages.azure-graphrbac python27Packages.azure-loganalytics python27Packages.azure-mgmt-advisor python27Packages.azure-mgmt-applicationinsights python27Packages.azure-mgmt-authorization python27Packages.azure-mgmt-batch python27Packages.azure-mgmt-batchai python27Packages.azure-mgmt-billing python27Packages.azure-mgmt-cdn python27Packages.azure-mgmt-cognitiveservices python27Packages.azure-mgmt-commerce python27Packages.azure-mgmt-common python27Packages.azure-mgmt-compute python27Packages.azure-mgmt-consumption python27Packages.azure-mgmt-containerinstance python27Packages.azure-mgmt-containerservice python27Packages.azure-mgmt-cosmosdb python27Packages.azure-mgmt-datafactory python27Packages.azure-mgmt-datalake-analytics python27Packages.azure-mgmt-datalake-store python27Packages.azure-mgmt-datamigration python27Packages.azure-mgmt-devspaces python27Packages.azure-mgmt-devtestlabs python27Packages.azure-mgmt-dns python27Packages.azure-mgmt-eventgrid python27Packages.azure-mgmt-eventhub python27Packages.azure-mgmt-hanaonazure python27Packages.azure-mgmt-iotcentral python27Packages.azure-mgmt-iothub python27Packages.azure-mgmt-iothubprovisioningservices python27Packages.azure-mgmt-keyvault python27Packages.azure-mgmt-loganalytics python27Packages.azure-mgmt-logic python27Packages.azure-mgmt-machinelearningcompute python27Packages.azure-mgmt-managementgroups python27Packages.azure-mgmt-managementpartner python27Packages.azure-mgmt-maps python27Packages.azure-mgmt-marketplaceordering python27Packages.azure-mgmt-media python27Packages.azure-mgmt-monitor python27Packages.azure-mgmt-msi python27Packages.azure-mgmt-network python27Packages.azure-mgmt-notificationhubs python27Packages.azure-mgmt-policyinsights python27Packages.azure-mgmt-powerbiembedded python27Packages.azure-mgmt-rdbms python27Packages.azure-mgmt-recoveryservices python27Packages.azure-mgmt-recoveryservicesbackup python27Packages.azure-mgmt-redis python27Packages.azure-mgmt-relay python27Packages.azure-mgmt-reservations python27Packages.azure-mgmt-resource python27Packages.azure-mgmt-scheduler python27Packages.azure-mgmt-search python27Packages.azure-mgmt-servicebus python27Packages.azure-mgmt-servicefabric python27Packages.azure-mgmt-signalr python27Packages.azure-mgmt-sql python27Packages.azure-mgmt-storage python27Packages.azure-mgmt-subscription python27Packages.azure-mgmt-trafficmanager python27Packages.azure-mgmt-web python27Packages.azure-servicebus python27Packages.azure-servicefabric python27Packages.msrest python27Packages.msrestazure python27Packages.vsts python27Packages.vsts-cd-manager python37Packages.azure-applicationinsights python37Packages.azure-batch python37Packages.azure-core python37Packages.azure-eventgrid python37Packages.azure-functions-devops-build python37Packages.azure-graphrbac python37Packages.azure-identity python37Packages.azure-keyvault python37Packages.azure-keyvault-certificates python37Packages.azure-keyvault-keys python37Packages.azure-keyvault-secrets python37Packages.azure-loganalytics python37Packages.azure-mgmt-advisor python37Packages.azure-mgmt-apimanagement python37Packages.azure-mgmt-appconfiguration python37Packages.azure-mgmt-applicationinsights python37Packages.azure-mgmt-authorization python37Packages.azure-mgmt-batch python37Packages.azure-mgmt-batchai python37Packages.azure-mgmt-billing python37Packages.azure-mgmt-botservice python37Packages.azure-mgmt-cdn python37Packages.azure-mgmt-cognitiveservices python37Packages.azure-mgmt-commerce python37Packages.azure-mgmt-common python37Packages.azure-mgmt-compute python37Packages.azure-mgmt-consumption python37Packages.azure-mgmt-containerinstance python37Packages.azure-mgmt-containerregistry python37Packages.azure-mgmt-containerservice python37Packages.azure-mgmt-core python37Packages.azure-mgmt-cosmosdb python37Packages.azure-mgmt-datafactory python37Packages.azure-mgmt-datalake-analytics python37Packages.azure-mgmt-datalake-store python37Packages.azure-mgmt-datamigration python37Packages.azure-mgmt-deploymentmanager python37Packages.azure-mgmt-devspaces python37Packages.azure-mgmt-devtestlabs python37Packages.azure-mgmt-dns python37Packages.azure-mgmt-eventgrid python37Packages.azure-mgmt-eventhub python37Packages.azure-mgmt-hanaonazure python37Packages.azure-mgmt-hdinsight python37Packages.azure-mgmt-imagebuilder python37Packages.azure-mgmt-iotcentral python37Packages.azure-mgmt-iothub python37Packages.azure-mgmt-iothubprovisioningservices python37Packages.azure-mgmt-keyvault python37Packages.azure-mgmt-kusto python37Packages.azure-mgmt-loganalytics python37Packages.azure-mgmt-logic python37Packages.azure-mgmt-machinelearningcompute python37Packages.azure-mgmt-managedservices python37Packages.azure-mgmt-managementgroups python37Packages.azure-mgmt-managementpartner python37Packages.azure-mgmt-maps python37Packages.azure-mgmt-marketplaceordering python37Packages.azure-mgmt-media python37Packages.azure-mgmt-monitor python37Packages.azure-mgmt-msi python37Packages.azure-mgmt-netapp python37Packages.azure-mgmt-network python37Packages.azure-mgmt-notificationhubs python37Packages.azure-mgmt-policyinsights python37Packages.azure-mgmt-powerbiembedded python37Packages.azure-mgmt-privatedns python37Packages.azure-mgmt-rdbms python37Packages.azure-mgmt-recoveryservices python37Packages.azure-mgmt-recoveryservicesbackup python37Packages.azure-mgmt-redhatopenshift python37Packages.azure-mgmt-redis python37Packages.azure-mgmt-relay python37Packages.azure-mgmt-reservations python37Packages.azure-mgmt-resource python37Packages.azure-mgmt-scheduler python37Packages.azure-mgmt-search python37Packages.azure-mgmt-security python37Packages.azure-mgmt-servicebus python37Packages.azure-mgmt-servicefabric python37Packages.azure-mgmt-signalr python37Packages.azure-mgmt-sql python37Packages.azure-mgmt-sqlvirtualmachine python37Packages.azure-mgmt-storage python37Packages.azure-mgmt-subscription python37Packages.azure-mgmt-trafficmanager python37Packages.azure-mgmt-web python37Packages.azure-multiapi-storage python37Packages.azure-servicebus python37Packages.azure-servicefabric python37Packages.azure-storage-file-share python37Packages.msrest python37Packages.msrestazure python37Packages.vsts python37Packages.vsts-cd-manager

@drewrisinger
Copy link
Contributor

@jonringer I'm still seeing the title of the commit misspelled on the web.
13c3501

@colemickens
Copy link
Member

I guess this is sort of expected?

$ nixpkgs-review pr 85826
...
3 packages failed to build:
python27Packages.azure python37Packages.azure python38Packages.azure
...

But the build output in the resulting shell works fine based on some sanity checks.

Thanks for maintaining this!

@colemickens
Copy link
Member

Should the metapackages be marked as broken or supported? Or is this just how nixpkgs-review works?

@jonringer
Copy link
Contributor Author

jonringer commented May 2, 2020 •
edited
Loading

no, I marked that package broken a long time ago... It's now officially deprecated. No one should use that. Too delicate with over 200+ azure packages.

@jonringer jonringer merged commit 9d6d4f8 into NixOS:master May 2, 2020
@jonringer jonringer deleted the update-azure branch May 2, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@drewrisinger drewrisinger

@bendlas bendlas

@kamadorueda kamadorueda

@olcai olcai

@colemickens colemickens

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @drewrisinger @colemickens @FRidh