Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pythonPackages.stem: unmarked as broken #85896

Closed
wants to merge 1 commit into from
Closed

[20.03] pythonPackages.stem: unmarked as broken #85896

wants to merge 1 commit into from
+0 −1

Conversation

paumr
Copy link
Contributor

@paumr paumr commented Apr 23, 2020

The package was marked broken but seems to work on 20.03

@paumr paumr requested review from FRidh and jonringer as code owners April 23, 2020 23:09
@ofborg ofborg bot added 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 23, 2020
cole-h
cole-h requested changes Apr 24, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already asked in IRC to amend the commit, but one more thing while you're touching this file: Ignore me (:

@paumr
pythonPackages.stem: unmarked as broken

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
8a2e53a
@paumr paumr changed the title marked stem as not-broken pythonPackages.stem: unmarked as broken Apr 24, 2020
@drewrisinger
Copy link
Contributor

suggestion: change title to [20.03] ...
@GrahamcOfBorg build python27Packages.stem python37Packages.stem python38Packages.stem

@paumr paumr changed the title pythonPackages.stem: unmarked as broken [20.03] pythonPackages.stem: unmarked as broken Apr 24, 2020
@drewrisinger
Copy link
Contributor

drewrisinger commented Apr 24, 2020 •
edited
Loading

Best as I can tell, it fails on python3.8 due to platform.linux_distribution() being removed on py38 (see ofborg log, relevant line I found):

operating system version...                          failed
module 'platform' has no attribute 'linux_distribution'

If you want to unbreak, you should either patch it or see if there's a new upstream version that works with py38

drewrisinger
drewrisinger suggested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should either work on py38 or be disabled on py38.

To work on py38, I suggest adding pythonPackages.distro to build, and then patching the offending line to use distro.linux_distribution()
(e.g. via substituteInPlace FILE_NAME --replace "platform.linux_distribution(" "distro.linux_distribution(")

@drewrisinger
Copy link
Contributor

whoops. Looks like this is a duplicate PR of #85642. That one includes update to 1.8.0. I'd recommend taking that one instead.

@drewrisinger drewrisinger mentioned this pull request Apr 24, 2020
Closed
10 tasks
@paumr
Copy link
Contributor Author

paumr commented Apr 25, 2020

whoops. Looks like this is a duplicate PR of #85642. That one includes update to 1.8.0. I'd recommend taking that one instead.

Alright, thanks!
I'll close this PR in favor of #85642

@paumr paumr closed this Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h

@drewrisinger drewrisinger

@FRidh FRidh

@jonringer jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paumr @drewrisinger @cole-h