xcbuild: add support for exporting sdk info #85844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewbauer
approved these changes
Apr 23, 2020
|
@worldofpeace Can you merge this, or let me know what i should be doing to move this forward? Thanks! |
|
@virusdave Hi, I would merge this solely off the fact @matthewbauer approves, but I'm wondering if we want a mass rebuild on darwin for master where it isn't critical. I'm suspecting not, so could you rebase onto staging? |
"Real" xcodebuild allows using `xcodebuild -version -sdk` without an sdk version argument, which will dump sdk info for all the installed sdks. Bazel"s "xcode cc toolchain setup on mac" process uses this to determine which SDK version is actually installed. This change allows using a nix-supplied pinned compiler and build system under bazel.
virusdave
force-pushed
the
dnicponski/scratch/better_sdk_version_support
branch
from
1d2d6e1
to
c3c3f68
Compare
virusdave
requested review from
Ericson2314,
FRidh and
jonringer
as code owners
Sure, done! For my benefit, what's the difference between |
ofborg
bot
added
6.topic: golang
6.topic: nixos
6.topic: python
6.topic: stdenv
|
Thanks for this ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Real" xcodebuild allows using
xcodebuild -version -sdkwithoutan sdk version argument, which will dump sdk info for all the
installed sdks.
Bazel"s "xcode cc toolchain setup on mac" process uses this
to determine which SDK version is actually installed. This
change allows using a nix-supplied pinned compiler and build
system under bazel.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)