Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer test: Fix grub extraConfig syntax #85832

Merged
merged 1 commit into from
Apr 23, 2020
Merged

installer test: Fix grub extraConfig syntax #85832

merged 1 commit into from
Apr 23, 2020
+1 −1

Conversation

benley
Copy link
Member

@benley benley commented Apr 23, 2020

Motivation for this change

It looks like terminal_output.serial is incorrect, according to the grub documentation:
https://www.gnu.org/software/grub/manual/grub/html_node/Serial-terminal.html

Related PR: #79406

cc @nh2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@benley
installer test: Fix grub extraConfig syntax
f09b8be 
It looks like `terminal_output.serial` is incorrect, according to the
grub documentation:

https://www.gnu.org/software/grub/manual/grub/html_node/Serial-terminal.html

Related PR: NixOS#79406
@benley benley mentioned this pull request Apr 23, 2020
Merged
10 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 23, 2020
nh2
nh2 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks right to me.

It would be interesting to know why this was never noticed.

@edolstra in a65b5ec, was the In the installer test, redirect GRUB output to the serial port. intended for debugging purposes when something went wrong? Do you know whether it ever worked?

@flokli
Copy link
Contributor

flokli commented Apr 23, 2020

I also have a

terminal_input serial console; terminal_output serial console

mostly everywhere, so I doubt this ever worked that way.

@flokli flokli merged commit 06a34e6 into NixOS:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benley @flokli @nh2