Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go tools/linters/language servers #85868

Merged
merged 10 commits into from
Apr 24, 2020
Merged

Update go tools/linters/language servers #85868

merged 10 commits into from
Apr 24, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

Mic92 added 10 commits April 23, 2020 15:28

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim
gometalinter development has stopped. golangci-lint is the replacement
@Mic92 Mic92 requested a review from jonringer as a code owner April 23, 2020 14:34
@Mic92
Copy link
Member Author

Mic92 commented Apr 23, 2020

@GrahamcOfBorg eval

1 similar comment
@Mic92
Copy link
Member Author

Mic92 commented Apr 23, 2020

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot added 6.topic: vim 8.has: documentation This PR adds or changes documentation 8.has: clean-up 8.has: package (new) This PR adds a new package labels Apr 23, 2020
@ofborg ofborg bot requested a review from jagajaga April 23, 2020 19:11
@Mic92 Mic92 merged commit 2bba291 into NixOS:master Apr 24, 2020
@Mic92 Mic92 deleted the go-tooling branch April 24, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants