New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rmapi: init at 0.0.11 #85898
rmapi: init at 0.0.11 #85898
Conversation
Please switch to |
Oh I see you commented at ryantm/nixpkgs-update#203, I think it'll work out for you if you'd not only rename the variable |
This works:
|
@Enteee, personally, I like this PR much more then yours - it's just so much cleaner and regular. I think I've sort of understood now what was your motivation behind the IFD thing, it's just that I didn't catch initially that you tried to push Nix support upstream at juruen/rmapi#78 . Never the less, I'm still a bit puzzled - almost every Go app that we ship doesn't include I think you'll like the yet unstable feature flakes - NixOS/rfcs#49 . When it'll stabilized, it'll be possible to do cool stuff like you tried in #74657 with less workarounds. |
@doronbehar Oh nice it works now. I wonder why it gave me an empty output before (even though the build log appeared to get all the dependencies and actually compile it). Nonetheless I've updated it so i think it ought to be good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes build and appears to be running as should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Motivation for this change
Add the rMAPI tool.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)