Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/package/<content-type>/<unique-id> gives 200 for unknown unique-id #34

Closed
frosch123 opened this issue Apr 23, 2020 · 0 comments
Closed

/package/<content-type>/<unique-id> gives 200 for unknown unique-id #34

frosch123 opened this issue Apr 23, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers prio: low This issue should be fixed, but we could do without

Comments

@frosch123
Copy link
Member

frosch123 commented Apr 23, 2020 •
edited

Request:
GET /package/<content-type>/<unique-id>
with an unknown unique-id.

Expected: Response 404

Currently: Response 200 with empty json {}.
@frosch123 frosch123 added bug Something isn't working good first issue Good for newcomers prio: low This issue should be fixed, but we could do without labels Apr 23, 2020
TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
@TrueBrain
Fix OpenTTD#35, OpenTTD#34: return a 404 if the unique-id / upload-da…
0fdcba3 
…te does not exist
TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
@TrueBrain
Fix OpenTTD#35, OpenTTD#34: return a 404 if the unique-id / upload-da…
80a385c 
…te does not exist
TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
@TrueBrain
Fix OpenTTD#35, OpenTTD#34: return a 404 if the unique-id / upload-da…
d5824ec 
…te does not exist
TrueBrain added a commit that referenced this issue Apr 25, 2020
@TrueBrain
Fix #35, #34: return a 404 if the unique-id / upload-date does not exist
04614ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers prio: low This issue should be fixed, but we could do without
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrueBrain @frosch123