Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/package/<content-type>/<unique-id>/<upload-date> gives 500 for unknown unique-id/upload-date #35

Closed
frosch123 opened this issue Apr 23, 2020 · 2 comments
Labels
bug Something isn't working prio: critical This issue is blocking people from using the system in a normal way

Comments

@frosch123
Copy link
Member

Request:
GET /package///
with an unknown unique-id or upload-date.

Expected: Response 404

Currently: Response 500

@TrueBrain TrueBrain added bug Something isn't working prio: critical This issue is blocking people from using the system in a normal way labels Apr 23, 2020
@TrueBrain
Copy link
Member

I have a hard time reproducing this. Can you give a more complete URL that fails? (as /package/// works for example).

I have tested several things, but for example /package/base-graphics/ab/de returns the (correct) error: {"message": "unique_id is invalid"} as a 400.

Or do you have any backtrace I can look at?

@TrueBrain
Copy link
Member

Ah, found anURL that breaks:
/package/base-graphics/abcedf12/2020-04-12T14:02:28+00:00

TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio: critical This issue is blocking people from using the system in a normal way
Projects
None yet
Development

No branches or pull requests

2 participants