Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twitter-color-emoji: 12.1.2 -> 12.1.5 #85889

Merged
merged 1 commit into from Apr 24, 2020
Merged

twitter-color-emoji: 12.1.2 -> 12.1.5 #85889

merged 1 commit into from Apr 24, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Apr 23, 2020

Motivation for this change

Twemoji version bump, plus a Fedora patch update to fix emoji size: https://src.fedoraproject.org/rpms/twitter-twemoji-fonts/c/282c789d3742d223968a7ddcae6e65374f6dcae1?branch=master

Didn’t finish building locally because Zopfli is really slow, let’s saddle ofborg with it instead…

cc @jtojnar – out of curiosity, is there any particular reason to keep the ImageMagick → GraphicsMagick patch around, other than keeping close to the Fedora upstream? It seems like the only functional change it had was accidental…

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 23, 2020

Hmm, I do not actually remember. Maybe I was not sure if the fedora patch does not also change some other parameters.

@emilazy
Copy link
Member Author

emilazy commented Apr 23, 2020

Yeah, I'm not wholly confident either (maybe that -extent is doing something?) so I've kept it.

@ofborg ofborg bot requested a review from jtojnar April 23, 2020 20:46
jtojnar
jtojnar approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The package builds (37 min on my laptop).
  • nixosTests.fontconfig-default-fonts succeeds.

@jtojnar jtojnar merged commit 79743fe into NixOS:master Apr 24, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2020

Thanks.

@emilazy emilazy deleted the twitter-color-emoji-12.1.5 branch April 24, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilazy @jtojnar