Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache validation result of individual uploaded files #36

Open
frosch123 opened this issue Apr 23, 2020 · 1 comment
Open

Cache validation result of individual uploaded files #36

frosch123 opened this issue Apr 23, 2020 · 1 comment
Labels
enhancement New feature or request prio: high This issue should be fixed when we get the time

Comments

@frosch123
Copy link
Member

Validation of big files (I tried a NewGRF with 850 MB) takes several seconds (probably computing MD5). The validation is repeated for every PUT/GET, even when only updating meta-data like description.

Please cache the validation result of uploaded files, if they do not change.
@frosch123 frosch123 added enhancement New feature or request prio: low This issue should be fixed, but we could do without labels Apr 23, 2020
@TrueBrain
Copy link
Member

TrueBrain commented Apr 23, 2020 •
edited

This is not completely trivial to implement, because of the many places the session object can be modified.

I suggest to make this change while also refactoring some of the code, so that session dict becomes an object. After that it is a lot easier to invalidate the cache. And .. it makes the code a lot better :D

As this hurts performance, increasing priority (during those few seconds, the API stalls for everyone, as this is disk I/O)

@TrueBrain TrueBrain added prio: high This issue should be fixed when we get the time and removed prio: low This issue should be fixed, but we could do without labels Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request prio: high This issue should be fixed when we get the time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TrueBrain @frosch123