Implementation of a CAS store #3528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
reviewed
Apr 30, 2020
| @@ -799,6 +799,9 @@ class DerivationGoal : public Goal | |||
| /* Whether this is a fixed-output derivation. */ | |||
| bool fixedOutput; | |||
|
|
|||
| /* Whether this is a content adressed derivation */ | |||
| bool contentAddressed = false; | |||
There was a problem hiding this comment.
Not implementing anything here, just throwing an error if a derivation sets `__contentAddressed = true` without `--experimental-features content-addressed-paths` (and also with it as there's nothing implemented yet)
Only works for a local store, and we can't depend on them
Things build − and the output paths are correct, but the paths aren't correctly registred yet
It only returns a really valid value for `LocalFSStore`, but we should extend the store protocol at some point to make it work for any store, so we might as well put it here right now − esp. given that it simplifies it usage a lot
If a derivation doesn't depend on a CA derivation (and isn't CA itself), then make sure that its out path isn't changed
Extend the daemon protocol to give add the `queryOutPath` operation
Inline the build of the CA derivation to make things simpler
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New implementation of NixOS/rfcs#62 (replaces the old prototype from #3262)
Currently at a very early stage:
/cc @edolstra @Ericson2314 @layus