Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nginx: update to 1.18.0 #85856

Merged
merged 2 commits into from Apr 24, 2020
Merged

nginx: update to 1.18.0 #85856

merged 2 commits into from Apr 24, 2020

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Apr 23, 2020

Motivation for this change

Update nginxStable and ngiunxMainline to 1.18.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 23, 2020

@GrahamcOfBorg test nginx nginx-etag nginx-pubhtml nginx-sso

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 23, 2020

cc @flokli @aanderse @Mic92 @delroth @jtojnar @danbst

@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2020

Changes looking fine: https://nginx.org/en/CHANGES-1.18

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 24, 2020

@GrahamcOfBorg test nginx nginx-etag nginx-pubhtml nginx-sso nghttpx

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 24, 2020

@GrahamcOfBorg test nghttpx

@Izorkin
Copy link
Contributor Author

Izorkin commented Apr 24, 2020

@GrahamcOfBorg build nginxStable nginxMainline

@flokli
Copy link
Contributor

flokli commented Apr 24, 2020

Ran some tests locally as well. Let's merge this in - thanks!

@flokli flokli merged commit 6e89b44 into NixOS:master Apr 24, 2020
@Izorkin Izorkin deleted the nginx-update branch April 25, 2020 04:50
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Apr 27, 2020
@flokli @dtzWill
Merge pull request NixOS#85856 from Izorkin/nginx-update
d015787 
nginx: update to 1.18.0
(cherry picked from commit 6e89b44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @jtojnar @flokli