Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.manticore: init at 0.3.5 #85810

Merged
merged 3 commits into from Jan 12, 2021
Merged

pythonPackages.manticore: init at 0.3.5 #85810

merged 3 commits into from Jan 12, 2021

Conversation

arcz
Copy link
Member

@arcz arcz commented Apr 22, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening your first PR! :)

Some comments (please try to apply to relevant packages):

Please create a commit per package addition, to follow CONTRIBUTING.md guidelines

There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors.


----------------------------------------------------------------------
Ran 0 tests in 0.000s

maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/crytic-compile/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/crytic-compile/default.nix Outdated Show resolved Hide resolved
@arcz arcz force-pushed the init-manticore branch 2 times, most recently from a447ee7 to eadaf06 Compare April 23, 2020 15:50
@arcz arcz changed the title manticore: init at 0.3.3 pythonPackages.manticore: init at 0.3.3 Apr 23, 2020
@arcz
Copy link
Member Author

arcz commented Apr 23, 2020 •
edited

@jonringer thank you for the review, I've learned a few things. I hope all the issues are addressed now.

drewrisinger
drewrisinger suggested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big issue is repeat of z3 package.

pkgs/development/python-modules/manticore/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/wasm/default.nix Show resolved Hide resolved
pkgs/development/python-modules/z3-solver/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/manticore/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyevmasm/default.nix Show resolved Hide resolved
drewrisinger
drewrisinger suggested changes Apr 27, 2020
View reviewed changes
pkgs/development/python-modules/pyevmasm/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyevmasm/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pyevmasm/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/manticore/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/manticore/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/manticore/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

Also, commits should be squashed before merge, one commit per package init. FWIW, git rebase -i master is what I usually use, and then edit the file that pops up.

@jonringer
Copy link
Contributor

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the commits.

Since your commits are quite complex, i would recommend using git rebase -i, but there should roughly be a commit per package, and 1 for adding yourself as a maintainer

@arcz arcz changed the title pythonPackages.manticore: init at 0.3.3 pythonPackages.manticore: init at 0.3.4 Oct 18, 2020
@arcz arcz force-pushed the init-manticore branch 3 times, most recently from 9e70bf2 to e75f082 Compare October 18, 2020 21:58
drewrisinger
drewrisinger approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff mostly LGTM. All comments here are woodshedding.
  • Commits LGTM
  • Builds via nix-review. Takes about 5 mins, incl. testing 👍 ✔️

pkgs/development/python-modules/crytic-compile/default.nix Outdated
, buildPythonPackage
, fetchPypi
, pysha3
, pythonOlder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be moved below fetchPypi

pkgs/development/python-modules/manticore/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/manticore/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/manticore/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/manticore/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/wasm/default.nix Outdated Show resolved Hide resolved
@arcz arcz force-pushed the init-manticore branch 2 times, most recently from 909a689 to b121916 Compare October 22, 2020 20:27
@arcz
Copy link
Member Author

arcz commented Nov 5, 2020

@jonringer is there anything still missing here?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 85810 run on x86_64-darwin 1

8 packages built:
  • python27Packages.pyevmasm
  • python27Packages.wasm
  • python37Packages.manticore
  • python37Packages.pyevmasm
  • python37Packages.wasm
  • python38Packages.manticore
  • python38Packages.pyevmasm
  • python38Packages.wasm

jonringer
jonringer reviewed Nov 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/development/python-modules/manticore/default.nix Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 85810 run on x86_64-linux 1

9 packages built:
  • python37Packages.manticore
  • python37Packages.pyevmasm
  • python37Packages.wasm
  • python38Packages.manticore
  • python38Packages.pyevmasm
  • python38Packages.wasm
  • python39Packages.manticore
  • python39Packages.pyevmasm
  • python39Packages.wasm

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 85810 run on x86_64-darwin 1

9 packages built:
  • python37Packages.manticore
  • python37Packages.pyevmasm
  • python37Packages.wasm
  • python38Packages.manticore
  • python38Packages.pyevmasm
  • python38Packages.wasm
  • python39Packages.manticore
  • python39Packages.pyevmasm
  • python39Packages.wasm

@thiagokokada
Copy link
Contributor

@arcz Can you fix the license and the merge conflict?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/313

@thiagokokada
Copy link
Contributor

Result of nixpkgs-review pr 85810 1

9 packages built:
  • python37Packages.manticore
  • python37Packages.pyevmasm
  • python37Packages.wasm
  • python38Packages.manticore
  • python38Packages.pyevmasm
  • python38Packages.wasm
  • python39Packages.manticore
  • python39Packages.pyevmasm
  • python39Packages.wasm

@jonringer
Copy link
Contributor

please resolve conflicts

@arcz arcz changed the title pythonPackages.manticore: init at 0.3.4 pythonPackages.manticore: init at 0.3.5 Jan 8, 2021
@arcz arcz requested a review from jonringer January 8, 2021 19:57
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 85810 run on x86_64-linux 1

9 packages built:
  • python37Packages.manticore
  • python37Packages.pyevmasm
  • python37Packages.wasm
  • python38Packages.manticore
  • python38Packages.pyevmasm
  • python38Packages.wasm
  • python39Packages.manticore
  • python39Packages.pyevmasm
  • python39Packages.wasm

@SuperSandro2000 SuperSandro2000 merged commit 9d275b7 into NixOS:master Jan 12, 2021
@arcz arcz deleted the init-manticore branch January 12, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@thiagokokada thiagokokada thiagokokada approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@arcz @drewrisinger @jonringer @SuperSandro2000 @thiagokokada @nixos-discourse @ryantm