[TablesNG] New test suite: caption + column width #23185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 22, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2161571
branch
2 times, most recently
from
c4bbdc6
to
c9e5618
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2161571
branch
from
c9e5618
to
791e5e1
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2161571
branch
4 times, most recently
from
627681a
to
14d7e5a
Compare
Caption.html - Legacy fails the caption block %ge sizing test. Legacy computed caption block %ge from grid size. I've discussed with tab, and will try to make block %ge caption size be auto instead. - Browsers mostly agree on column-width.html test, 1 difference. It exausively tests how td and col sizes are combined to generate column width. Bug: 958381 Change-Id: I61d0e5a0e67d7fbb122ee5818917ee14d9801da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161571 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#771341}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2161571
branch
from
14d7e5a
to
30abbcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caption.html
Legacy fails the caption block %ge sizing test.
Legacy computed caption block %ge from grid size.
I've discussed with tab, and will try to make
block %ge caption size be auto instead.
Browsers mostly agree on column-width.html test, 1 difference.
It exausively tests how td and col sizes are combined
to generate column width.
Bug: 958381
Change-Id: I61d0e5a0e67d7fbb122ee5818917ee14d9801da0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161571
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771341}