Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vdirsyncer: fix failing test #85809

Merged
merged 1 commit into from Apr 22, 2020
Merged

vdirsyncer: fix failing test #85809

merged 1 commit into from Apr 22, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Apr 22, 2020 •
edited

Motivation for this change

It was filing to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@garbas garbas requested a review from andir April 22, 2020 20:40
@ofborg ofborg bot requested a review from gebner April 22, 2020 20:47
@garbas garbas mentioned this pull request Apr 22, 2020
Merged
10 tasks
@andir
Copy link
Member

andir commented Apr 22, 2020

Thank you <3

I was about to submit something regarding this upstream but the issue isn't as straight forward as I hoped (without restricting the click version).

@andir andir merged commit 1dcf798 into NixOS:master Apr 22, 2020
@garbas garbas deleted the fix-vdirsyncer branch April 22, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garbas @andir