Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix khal #85811

Merged
merged 1 commit into from Apr 24, 2020
Merged

Fix khal #85811

merged 1 commit into from Apr 24, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Apr 22, 2020 •
edited

Motivation for this change

Test was broken.

This PR dependson #85809

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@garbas garbas requested a review from andir April 22, 2020 20:53
@ofborg ofborg bot requested a review from gebner April 22, 2020 21:02
@andir
Copy link
Member

andir commented Apr 22, 2020

Works for me but I am getting weird warnings that I wasn't getting with the previously working version on master:

warning: In event c0a64b13-0ba5-41d6-99e3-069a75171076.ics, DTSTART has a timezone, but UNTIL does not. This might lead to errenous repeating instances (like missing the last intended instance or adding an extra one).

@garbas
Copy link
Member Author

garbas commented Apr 22, 2020 •
edited

Which was the previous working version? I'm just about to setup khal. I would say this PR leaves khal in the same state as before. since I'm only fixing the test.

@andir
Copy link
Member

andir commented Apr 22, 2020 •
edited

I just disabled the tests while using 22a3bf9

@garbas
Copy link
Member Author

garbas commented Apr 24, 2020

I just disabled the tests while using 22a3bf9

I'm not sure I understand what above link has to do with this PR. It might a typo or I need more handholding where to look 😄

@garbas garbas merged commit 69bac39 into NixOS:master Apr 24, 2020
@garbas garbas deleted the fix-khal branch April 24, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andir andir Awaiting requested review from andir

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garbas @andir