Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luaPackages.luaexpat: unbreak, it builds just fine #85814

Merged
merged 1 commit into from Apr 22, 2020
Merged

luaPackages.luaexpat: unbreak, it builds just fine #85814

merged 1 commit into from Apr 22, 2020

Conversation

andir
Copy link
Member

@andir andir commented Apr 22, 2020

Motivation for this change

While upgrading my Jabber server to 20.03 I noticed that the package was
marked broken but builds just fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
luaPackages.luaexpat: unbreak, it builds just fine
a01979a 
While upgrading my Jabber server to 20.03 I noticed that the package was
marked broken but builds just fine.
@andir andir requested a review from worldofpeace April 22, 2020 21:21
@andir
Copy link
Member Author

andir commented Apr 22, 2020

@GrahamcOfBorg test prosody

@teto teto merged commit 24e0307 into NixOS:release-20.03 Apr 22, 2020
@andir andir deleted the 20.03/luaexpat branch April 23, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @teto