Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apostrophe: add alias from uberwriter #85881

Merged
merged 1 commit into from Apr 29, 2020
Merged

apostrophe: add alias from uberwriter #85881

merged 1 commit into from Apr 29, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Apr 23, 2020 •
edited

Motivation for this change

The package is part of NixOS 20.03 as pkgs.uberwriter, so the rename to Apostrophe might be confusing for some users, when the change is incorporated into a NixOS release. This alias eases future transition.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
apostrophe: add alias from uberwriter
9f56d35 
The pkg is part of NixOS 20.03 as pkgs.uberwriter, so the rename
to apostrophe might be confusing for some users.
@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build uberwriter

@sternenseemann
Copy link
Member Author

@Mic92 Do you think this is worth doing now?

@Mic92 Mic92 merged commit 9ae6b51 into NixOS:master Apr 29, 2020
@sternenseemann sternenseemann deleted the apostrophe-alias branch April 29, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @Mic92