linux_*_hardened: index patches by major kernel version #85880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will avoid breaking the build whenever a non-major kernel update happens. In the update script, we map each kernel version to the latest patch for the latest kernel version less than or equal to what we have packaged.
Mic92
approved these changes
Apr 23, 2020
jonringer
approved these changes
Apr 23, 2020
|
Not sure why the tests didn't run... @GrahamcOfBorg test hardened latestKernel.hardened |
ofborg will only run if the attr matches exactly. It doesn't comprehend glob or expansion syntax. https://github.com/NixOS/ofborg#automatic-building |
|
I explicitly poked it in the PR message, though; asked on IRC and it turns out the ofborg comment listener had been down for 12 hours :) Hopefully the queue will get to it before the next kernel version comes out >_> (edit: oh, it already did!) |
NeQuissimus
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This will avoid breaking the build whenever a non-major kernel update happens. In the update script, we map each kernel version to the latest patch for the latest kernel version less than or equal to what we have packaged.
cc @Mic92 @jonringer
@GrahamcOfBorg test hardened latestKernel.hardened
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)