Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme release instructions #99

Merged
merged 2 commits into from Apr 23, 2020
Merged

Readme release instructions #99

merged 2 commits into from Apr 23, 2020

Conversation

andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Apr 22, 2020 •
edited

Closes #42

@andythenorth andythenorth mentioned this pull request Apr 22, 2020
Closed
LordAro
LordAro reviewed Apr 23, 2020
View reviewed changes
README.md Outdated

### 5.1) Reporting bugs

If you find any bugs with NML, please let us know preferrably via our [issue tracker](https://github.com/OpenTTD/nml/issues) or via the NML release topic on the [TT-Forums](https://www.tt-forums.net/viewtopic.php?f=68&t=48891).
Copy link
Member

@LordAro LordAro Apr 23, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No point reporting bugs via the forum topic, they should be here (GH)

TrueBrain
TrueBrain reviewed Apr 23, 2020
View reviewed changes
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not validate the text, just things that jumped out.

README.md Outdated
This is done manually, and commits are grouped by type.
Example: https://github.com/OpenTTD/nml/blob/master/docs/changelog.txt
3. Decide what the version number will be.
4. Publish a new release using the release tool in the Github project: https://github.com/OpenTTD/nml/releases/new
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub. Captial h.

README.md Outdated
Example: https://github.com/OpenTTD/nml/blob/master/docs/changelog.txt
3. Decide what the version number will be.
4. Publish a new release using the release tool in the Github project: https://github.com/OpenTTD/nml/releases/new
5. GitHub Actions will build the release and publish to OpenTTD CDN.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"OpenTTD CDN" -> "PyPi"

@LordAro LordAro merged commit d5bd683 into OpenTTD:master Apr 23, 2020
@andythenorth andythenorth mentioned this pull request Apr 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain left review comments

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to release nmlc, including building a windows binary
3 participants
@andythenorth @TrueBrain @LordAro