Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome3.file-roller: 3.36.1 -> 3.36.2 #85865

Merged
merged 1 commit into from Apr 23, 2020
Merged

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Apr 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 23, 2020

@GrahamcOfBorg eval

1 similar comment
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Apr 23, 2020
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay and seems to work. Thanks.

@jtojnar jtojnar merged commit 5b49b43 into NixOS:master Apr 23, 2020
@mmilata mmilata deleted the file-roller-3.36.2 branch April 23, 2020 19:32
@mmilata
Copy link
Member Author

mmilata commented Apr 23, 2020

@jtojnar thanks for merging - want me to backport this to 20.03?

@jtojnar
Copy link
Contributor

jtojnar commented Apr 23, 2020

20.03 is stuck on GNOME 3.34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants