Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powerline-go: 1.15.0 -> 1.17.0 #85864

Merged
merged 1 commit into from Apr 24, 2020
Merged

powerline-go: 1.15.0 -> 1.17.0 #85864

merged 1 commit into from Apr 24, 2020

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Apr 23, 2020 •
edited

Motivation for this change

Update powerline-go to the latest release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 23, 2020

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

please rebase your branch ontop of master, and force push to fix eval:

git pull -r origin/master
git push --force .. ..

@ofborg ofborg bot requested review from kalbasit and sifmelcara April 23, 2020 19:35
@xrelkd xrelkd changed the title powerline-go: 1.15.0 -> 1.16.0 powerline-go: 1.15.0 -> 1.16.1 Apr 24, 2020
@xrelkd xrelkd changed the title powerline-go: 1.15.0 -> 1.16.1 powerline-go: 1.15.0 -> 1.17.0 Apr 24, 2020
@Mic92 Mic92 merged commit 320edf2 into NixOS:master Apr 24, 2020
@xrelkd
Copy link
Contributor Author

xrelkd commented Apr 24, 2020

@Mic92 @jonringer Thank you!

@xrelkd xrelkd deleted the update/powerline-go branch April 24, 2020 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

@sifmelcara sifmelcara Awaiting requested review from sifmelcara

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @Mic92 @jonringer