Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase upload-token expiration time #37

Closed
frosch123 opened this issue Apr 23, 2020 · 1 comment
Closed

Increase upload-token expiration time #37

frosch123 opened this issue Apr 23, 2020 · 1 comment
Labels
bug Something isn't working prio: low This issue should be fixed, but we could do without

Comments

@frosch123
Copy link
Member

Some content is approaching a size of 1 GB.
With some connections a upload timeout of 15 minutes is rather harsh.

It's also likely that people would start their GB upload, and go for a walk.

So I suggest to make upload-tokens expire together with the session, and not on their own.

@frosch123 frosch123 added bug Something isn't working prio: low This issue should be fixed, but we could do without labels Apr 23, 2020
@TrueBrain
Copy link
Member

I think there are two fixes to be made:

Also invalidate uploads when a session expires.
Increase the time an upload expires.

TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
With this, it now always times out after the session times out.
TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
With this, it now always times out after the session times out.
TrueBrain added a commit to TrueBrain/OpenTTD-bananas-api that referenced this issue Apr 25, 2020
With this, it now always times out after the session times out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio: low This issue should be fixed, but we could do without
Projects
None yet
Development

No branches or pull requests

2 participants