Add plugin hooks required for the encrypted links plugin #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
force-pushed
the
plugin-hooks
branch
from
9dda74f
to
7f02863
Compare
grahamc
reviewed
Apr 24, 2020
adisbladis
commented
Apr 24, 2020
grahamc
reviewed
Apr 24, 2020
| class DeploymentPlugin(Protocol): | ||
| def physical_spec( | ||
| self, d: Deployment | ||
| ) -> Dict[str, List[Dict[Tuple[str, ...], Any]]]: |
There was a problem hiding this comment.
I think we should probably give this type a name, like:
MachineSpecs = Dict[str, List[Dict[Tuple[str, ...], Any]]]
or something?
There was a problem hiding this comment.
Yes, this type is incredibly awkward, it's so awkward in fact that I don't expect plugin authors to directly type these structures.
Two things I have considered instead:
- Simple dict:
{
"networking": {"hostName": "foobar"}
}- Abstract away in a class:
spec = Spec()
spec.add_option("networking.hostName", "foobar")
|
This PR has been rolled up in #1383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is being used by https://github.com/adisbladis/nixops-encrypted-links