Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msmtp: hotfix for broken queueing in 1.8.8 #85846

Closed
wants to merge 1 commit into from
Closed

msmtp: hotfix for broken queueing in 1.8.8 #85846

wants to merge 1 commit into from

Conversation

peterhoeg
Copy link
Member

1.8.8 breaks msmtp-queue causing mails to be continuously resent as they are not removed from the queue.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg requested a review from rycee April 23, 2020 06:03
@peterhoeg peterhoeg mentioned this pull request Apr 23, 2020
Closed
@FRidh
Copy link
Member

FRidh commented Apr 23, 2020

Add a comment in the code along with a long to an upstream issue.

@peterhoeg peterhoeg changed the title Revert "msmtp: 1.8.7 -> 1.8.8" msmtp: hotfix for broken queueing in 1.8.8 Apr 23, 2020
rycee pushed a commit that referenced this pull request Apr 23, 2020
@peterhoeg @rycee
msmtp: fix for broken queueing
920c51e 
PR #85846
@rycee
Copy link
Member

rycee commented Apr 23, 2020

Thanks for the quick discovery and fix! I've tried it out a bit and it Works For Me™. Rebased to master in 920c51e.

@rycee rycee closed this Apr 23, 2020
@peterhoeg peterhoeg deleted the d/msmtp branch April 23, 2020 09:01
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jun 5, 2020
@peterhoeg @dtzWill
msmtp: fix for broken queueing
7fa3761 
PR NixOS#85846

(cherry picked from commit 920c51e)
@peterhoeg peterhoeg restored the d/msmtp branch October 6, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @FRidh @rycee