fix haskellPackages.headed-megaparsec #85847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdepillabout
approved these changes
Apr 23, 2020
cdepillabout
requested changes
Apr 23, 2020
ofborg
bot
added
6.topic: nixos
6.topic: pantheon
chrbauer
force-pushed
the
fix/haskellPackages.headed-megaparsec
branch
from
de11bfc
to
48aebe1
Compare
ofborg
bot
removed
6.topic: TeX
| @@ -1523,4 +1523,7 @@ self: super: { | |||
| sha256 = "sha256:0xbfhzhzg94b4r5qy5dg1c40liswwpqarrc2chcwgfbfnrmwkfc2"; | |||
| }); | |||
|
|
|||
| # Depends on selective >= 0.4, but the default of selective is 0.3 | |||
| headed-megaparsec = addBuildDepend super.headed-megaparsec super.selective_0_4_1; | |||
There was a problem hiding this comment.
I think normally we write this like the following:
headed-megaparsec = super.headed-megaparsec.override {
selective = self.selective_0_4_1;
};Please fix this up (and make sure it still compiles correctly).
chrbauer
force-pushed
the
fix/haskellPackages.headed-megaparsec
branch
from
48aebe1
to
8b36372
Compare
peti
force-pushed
the
haskell-updates
branch
4 times, most recently
from
50d38e7
to
e567a3b
Compare
|
@chrbauer Could you rebase this on |
chrbauer
force-pushed
the
fix/haskellPackages.headed-megaparsec
branch
from
8b36372
to
078f3ba
Compare
@cdepillabout it's now rebased again |
cdepillabout
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)