Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0321ceaf44fb
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8a966ceb0da1
Choose a head ref
  • 2 commits
  • 59 files changed
  • 2 contributors

Commits on Apr 21, 2020

  1. treewide: add bool type to enable options, or make use of mkEnableOption

    Add missing type information to manually specified enable options or replace them by mkEnableOption where appropriate.
    xaverdh committed Apr 21, 2020

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    dtzWill Will Dietz
    Copy the full SHA
    33d12d7 View commit details

Commits on Apr 23, 2020

  1. Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    dtzWill Will Dietz
    Copy the full SHA
    8a966ce View commit details
Showing with 71 additions and 175 deletions.
  1. +1 −0 nixos/modules/programs/cdemu.nix
  2. +1 −0 nixos/modules/programs/criu.nix
  3. +1 −0 nixos/modules/programs/systemtap.nix
  4. +1 −0 nixos/modules/programs/zsh/oh-my-zsh.nix
  5. +1 −0 nixos/modules/services/amqp/rabbitmq.nix
  6. +1 −6 nixos/modules/services/backup/mysql-backup.nix
  7. +1 −6 nixos/modules/services/backup/postgresql-backup.nix
  8. +1 −4 nixos/modules/services/databases/clickhouse.nix
  9. +1 −6 nixos/modules/services/databases/firebird.nix
  10. +1 −6 nixos/modules/services/databases/memcached.nix
  11. +1 −6 nixos/modules/services/databases/mongodb.nix
  12. +1 −4 nixos/modules/services/databases/virtuoso.nix
  13. +1 −6 nixos/modules/services/hardware/ratbagd.nix
  14. +1 −6 nixos/modules/services/hardware/thermald.nix
  15. +1 −4 nixos/modules/services/mail/spamassassin.nix
  16. +1 −0 nixos/modules/services/misc/autofs.nix
  17. +1 −7 nixos/modules/services/misc/cgminer.nix
  18. +1 −6 nixos/modules/services/misc/devmon.nix
  19. +1 −4 nixos/modules/services/misc/disnix.nix
  20. +1 −4 nixos/modules/services/misc/felix.nix
  21. +1 −0 nixos/modules/services/misc/ihaskell.nix
  22. +1 −4 nixos/modules/services/misc/safeeyes.nix
  23. +1 −0 nixos/modules/services/misc/svnserve.nix
  24. +4 −12 nixos/modules/services/misc/synergy.nix
  25. +2 −4 nixos/modules/services/network-filesystems/netatalk.nix
  26. +1 −4 nixos/modules/services/network-filesystems/rsyncd.nix
  27. +6 −0 nixos/modules/services/network-filesystems/xtreemfs.nix
  28. +1 −0 nixos/modules/services/network-filesystems/yandex-disk.nix
  29. +1 −0 nixos/modules/services/networking/amuled.nix
  30. +1 −6 nixos/modules/services/networking/babeld.nix
  31. +1 −6 nixos/modules/services/networking/bind.nix
  32. +1 −0 nixos/modules/services/networking/bitlbee.nix
  33. +1 −6 nixos/modules/services/networking/cntlm.nix
  34. +1 −0 nixos/modules/services/networking/flashpolicyd.nix
  35. +2 −6 nixos/modules/services/networking/gvpe.nix
  36. +1 −0 nixos/modules/services/networking/hostapd.nix
  37. +1 −6 nixos/modules/services/networking/ircd-hybrid/default.nix
  38. +2 −6 nixos/modules/services/networking/mailpile.nix
  39. +1 −0 nixos/modules/services/networking/ntp/chrony.nix
  40. +1 −0 nixos/modules/services/networking/ntp/ntpd.nix
  41. +1 −6 nixos/modules/services/networking/openfire.nix
  42. +1 −6 nixos/modules/services/networking/prayer.nix
  43. +1 −6 nixos/modules/services/networking/quassel.nix
  44. +1 −0 nixos/modules/services/networking/radvd.nix
  45. +1 −0 nixos/modules/services/networking/rdnssd.nix
  46. +2 −4 nixos/modules/services/networking/sabnzbd.nix
  47. +1 −0 nixos/modules/services/networking/shairport-sync.nix
  48. +1 −0 nixos/modules/services/networking/ssh/lshd.nix
  49. +1 −6 nixos/modules/services/networking/xinetd.nix
  50. +1 −6 nixos/modules/services/security/fprot.nix
  51. +1 −6 nixos/modules/services/system/kerberos/default.nix
  52. +1 −0 nixos/modules/services/system/localtime.nix
  53. +1 −0 nixos/modules/services/system/uptimed.nix
  54. +1 −0 nixos/modules/services/web-servers/jboss/default.nix
  55. +1 −0 nixos/modules/services/x11/desktop-managers/enlightenment.nix
  56. +1 −0 nixos/modules/services/x11/desktop-managers/gnome3.nix
  57. +1 −0 nixos/modules/services/x11/desktop-managers/kodi.nix
  58. +1 −0 nixos/modules/services/x11/display-managers/startx.nix
  59. +1 −0 nixos/modules/services/x11/hardware/wacom.nix
1 change: 1 addition & 0 deletions nixos/modules/programs/cdemu.nix
Original file line number Diff line number Diff line change
@@ -8,6 +8,7 @@ in {
options = {
programs.cdemu = {
enable = mkOption {
type = types.bool;
default = false;
description = ''
<command>cdemu</command> for members of
1 change: 1 addition & 0 deletions nixos/modules/programs/criu.nix
Original file line number Diff line number Diff line change
@@ -8,6 +8,7 @@ in {
options = {
programs.criu = {
enable = mkOption {
type = types.bool;
default = false;
description = ''
Install <command>criu</command> along with necessary kernel options.
1 change: 1 addition & 0 deletions nixos/modules/programs/systemtap.nix
Original file line number Diff line number Diff line change
@@ -8,6 +8,7 @@ in {
options = {
programs.systemtap = {
enable = mkOption {
type = types.bool;
default = false;
description = ''
Install <command>systemtap</command> along with necessary kernel options.
1 change: 1 addition & 0 deletions nixos/modules/programs/zsh/oh-my-zsh.nix
Original file line number Diff line number Diff line change
@@ -39,6 +39,7 @@ in
options = {
programs.zsh.ohMyZsh = {
enable = mkOption {
type = types.bool;
default = false;
description = ''
Enable oh-my-zsh.
1 change: 1 addition & 0 deletions nixos/modules/services/amqp/rabbitmq.nix
Original file line number Diff line number Diff line change
@@ -17,6 +17,7 @@ in {
options = {
services.rabbitmq = {
enable = mkOption {
type = types.bool;
default = false;
description = ''
Whether to enable the RabbitMQ server, an Advanced Message
7 changes: 1 addition & 6 deletions nixos/modules/services/backup/mysql-backup.nix
Original file line number Diff line number Diff line change
@@ -37,12 +37,7 @@ in

services.mysqlBackup = {

enable = mkOption {
default = false;
description = ''
Whether to enable MySQL backups.
'';
};
enable = mkEnableOption "MySQL backups";

calendar = mkOption {
type = types.str;
7 changes: 1 addition & 6 deletions nixos/modules/services/backup/postgresql-backup.nix
Original file line number Diff line number Diff line change
@@ -44,12 +44,7 @@ in {

options = {
services.postgresqlBackup = {
enable = mkOption {
default = false;
description = ''
Whether to enable PostgreSQL dumps.
'';
};
enable = mkEnableOption "PostgreSQL dumps";

startAt = mkOption {
default = "*-*-* 01:15:00";
5 changes: 1 addition & 4 deletions nixos/modules/services/databases/clickhouse.nix
Original file line number Diff line number Diff line change
@@ -11,10 +11,7 @@ with lib;

services.clickhouse = {

enable = mkOption {
default = false;
description = "Whether to enable ClickHouse database server.";
};
enable = mkEnableOption "ClickHouse database server";

};

7 changes: 1 addition & 6 deletions nixos/modules/services/databases/firebird.nix
Original file line number Diff line number Diff line change
@@ -40,12 +40,7 @@ in

services.firebird = {

enable = mkOption {
default = false;
description = ''
Whether to enable the Firebird super server.
'';
};
enable = mkEnableOption "the Firebird super server";

package = mkOption {
default = pkgs.firebirdSuper;
7 changes: 1 addition & 6 deletions nixos/modules/services/databases/memcached.nix
Original file line number Diff line number Diff line change
@@ -18,12 +18,7 @@ in

services.memcached = {

enable = mkOption {
default = false;
description = "
Whether to enable Memcached.
";
};
enable = mkEnableOption "Memcached";

user = mkOption {
default = "memcached";
7 changes: 1 addition & 6 deletions nixos/modules/services/databases/mongodb.nix
Original file line number Diff line number Diff line change
@@ -29,12 +29,7 @@ in

services.mongodb = {

enable = mkOption {
default = false;
description = "
Whether to enable the MongoDB server.
";
};
enable = mkEnableOption "the MongoDB server";

package = mkOption {
default = pkgs.mongodb;
5 changes: 1 addition & 4 deletions nixos/modules/services/databases/virtuoso.nix
Original file line number Diff line number Diff line change
@@ -13,10 +13,7 @@ with lib;

services.virtuoso = {

enable = mkOption {
default = false;
description = "Whether to enable Virtuoso Opensource database server.";
};
enable = mkEnableOption "Virtuoso Opensource database server";

config = mkOption {
default = "";
7 changes: 1 addition & 6 deletions nixos/modules/services/hardware/ratbagd.nix
Original file line number Diff line number Diff line change
@@ -10,12 +10,7 @@ in

options = {
services.ratbagd = {
enable = mkOption {
default = false;
description = ''
Whether to enable ratbagd for configuring gaming mice.
'';
};
enable = mkEnableOption "ratbagd for configuring gaming mice";
};
};

7 changes: 1 addition & 6 deletions nixos/modules/services/hardware/thermald.nix
Original file line number Diff line number Diff line change
@@ -8,12 +8,7 @@ in {
###### interface
options = {
services.thermald = {
enable = mkOption {
default = false;
description = ''
Whether to enable thermald, the temperature management daemon.
'';
};
enable = mkEnableOption "thermald, the temperature management daemon";

debug = mkOption {
type = types.bool;
5 changes: 1 addition & 4 deletions nixos/modules/services/mail/spamassassin.nix
Original file line number Diff line number Diff line change
@@ -12,10 +12,7 @@ in
options = {

services.spamassassin = {
enable = mkOption {
default = false;
description = "Whether to run the SpamAssassin daemon";
};
enable = mkEnableOption "the SpamAssassin daemon";

debug = mkOption {
default = false;
1 change: 1 addition & 0 deletions nixos/modules/services/misc/autofs.nix
Original file line number Diff line number Diff line change
@@ -19,6 +19,7 @@ in
services.autofs = {

enable = mkOption {
type = types.bool;
default = false;
description = ''
Mount filesystems on demand. Unmount them automatically.
8 changes: 1 addition & 7 deletions nixos/modules/services/misc/cgminer.nix
Original file line number Diff line number Diff line change
@@ -31,13 +31,7 @@ in

services.cgminer = {

enable = mkOption {
default = false;
description = ''
Whether to enable cgminer, an ASIC/FPGA/GPU miner for bitcoin and
litecoin.
'';
};
enable = mkEnableOption "cgminer, an ASIC/FPGA/GPU miner for bitcoin and litecoin";

package = mkOption {
default = pkgs.cgminer;
7 changes: 1 addition & 6 deletions nixos/modules/services/misc/devmon.nix
Original file line number Diff line number Diff line change
@@ -8,12 +8,7 @@ let
in {
options = {
services.devmon = {
enable = mkOption {
default = false;
description = ''
Whether to enable devmon, an automatic device mounting daemon.
'';
};
enable = mkEnableOption "devmon, an automatic device mounting daemon";
};
};

5 changes: 1 addition & 4 deletions nixos/modules/services/misc/disnix.nix
Original file line number Diff line number Diff line change
@@ -17,10 +17,7 @@ in

services.disnix = {

enable = mkOption {
default = false;
description = "Whether to enable Disnix";
};
enable = mkEnableOption "Disnix";

enableMultiUser = mkOption {
type = types.bool;
5 changes: 1 addition & 4 deletions nixos/modules/services/misc/felix.nix
Original file line number Diff line number Diff line change
@@ -17,10 +17,7 @@ in

services.felix = {

enable = mkOption {
default = false;
description = "Whether to enable the Apache Felix OSGi service";
};
enable = mkEnableOption "the Apache Felix OSGi service";

bundles = mkOption {
type = types.listOf types.package;
1 change: 1 addition & 0 deletions nixos/modules/services/misc/ihaskell.nix
Original file line number Diff line number Diff line change
@@ -15,6 +15,7 @@ in
options = {
services.ihaskell = {
enable = mkOption {
type = types.bool;
default = false;
description = "Autostart an IHaskell notebook service.";
};
5 changes: 1 addition & 4 deletions nixos/modules/services/misc/safeeyes.nix
Original file line number Diff line number Diff line change
@@ -16,10 +16,7 @@ in

services.safeeyes = {

enable = mkOption {
default = false;
description = "Whether to enable the safeeyes OSGi service";
};
enable = mkEnableOption "the safeeyes OSGi service";

};

1 change: 1 addition & 0 deletions nixos/modules/services/misc/svnserve.nix
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ in
services.svnserve = {

enable = mkOption {
type = types.bool;
default = false;
description = "Whether to enable svnserve to serve Subversion repositories through the SVN protocol.";
};
16 changes: 4 additions & 12 deletions nixos/modules/services/misc/synergy.nix
Original file line number Diff line number Diff line change
@@ -19,12 +19,8 @@ in
# !!! All these option descriptions needs to be cleaned up.

client = {
enable = mkOption {
default = false;
description = "
Whether to enable the Synergy client (receive keyboard and mouse events from a Synergy server).
";
};
enable = mkEnableOption "the Synergy client (receive keyboard and mouse events from a Synergy server)";

screenName = mkOption {
default = "";
description = ''
@@ -47,12 +43,8 @@ in
};

server = {
enable = mkOption {
default = false;
description = ''
Whether to enable the Synergy server (send keyboard and mouse events).
'';
};
enable = mkEnableOption "the Synergy server (send keyboard and mouse events)";

configFile = mkOption {
default = "/etc/synergy-server.conf";
description = "The Synergy server configuration file.";
6 changes: 2 additions & 4 deletions nixos/modules/services/network-filesystems/netatalk.nix
Original file line number Diff line number Diff line change
@@ -43,10 +43,7 @@ in
options = {
services.netatalk = {

enable = mkOption {
default = false;
description = "Whether to enable the Netatalk AFP fileserver.";
};
enable = mkEnableOption "the Netatalk AFP fileserver";

port = mkOption {
default = 548;
@@ -65,6 +62,7 @@ in

homes = {
enable = mkOption {
type = types.bool;
default = false;
description = "Enable sharing of the UNIX server user home directories.";
};
5 changes: 1 addition & 4 deletions nixos/modules/services/network-filesystems/rsyncd.nix
Original file line number Diff line number Diff line change
@@ -29,10 +29,7 @@ in
options = {
services.rsyncd = {

enable = mkOption {
default = false;
description = "Whether to enable the rsync daemon.";
};
enable = mkEnableOption "the rsync daemon";

motd = mkOption {
type = types.str;
6 changes: 6 additions & 0 deletions nixos/modules/services/network-filesystems/xtreemfs.nix
Original file line number Diff line number Diff line change
@@ -100,11 +100,13 @@ in

dir = {
enable = mkOption {
type = types.bool;
default = true;
description = ''
Whether to enable XtreemFS DIR service.
'';
};

uuid = mkOption {
example = "eacb6bab-f444-4ebf-a06a-3f72d7465e40";
description = ''
@@ -218,11 +220,13 @@ in

mrc = {
enable = mkOption {
type = types.bool;
default = true;
description = ''
Whether to enable XtreemFS MRC service.
'';
};

uuid = mkOption {
example = "eacb6bab-f444-4ebf-a06a-3f72d7465e41";
description = ''
@@ -354,11 +358,13 @@ in

osd = {
enable = mkOption {
type = types.bool;
default = true;
description = ''
Whether to enable XtreemFS OSD service.
'';
};

uuid = mkOption {
example = "eacb6bab-f444-4ebf-a06a-3f72d7465e42";
description = ''
1 change: 1 addition & 0 deletions nixos/modules/services/network-filesystems/yandex-disk.nix
Original file line number Diff line number Diff line change
@@ -21,6 +21,7 @@ in
services.yandex-disk = {

enable = mkOption {
type = types.bool;
default = false;
description = "
Whether to enable Yandex-disk client. See https://disk.yandex.ru/
1 change: 1 addition & 0 deletions nixos/modules/services/networking/amuled.nix
Original file line number Diff line number Diff line change
@@ -16,6 +16,7 @@ in
services.amule = {

enable = mkOption {
type = types.bool;
default = false;
description = ''
Whether to run the AMule daemon. You need to manually run "amuled --ec-config" to configure the service for the first time.
7 changes: 1 addition & 6 deletions nixos/modules/services/networking/babeld.nix
Original file line number Diff line number Diff line change
@@ -35,12 +35,7 @@ in

services.babeld = {

enable = mkOption {
default = false;
description = ''
Whether to run the babeld network routing daemon.
'';
};
enable = mkEnableOption "the babeld network routing daemon";

interfaceDefaults = mkOption {
default = null;
Loading