Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add title 'Package request' to issue template #85887

Closed
wants to merge 1 commit into from

Conversation

mehlon
Copy link
Contributor

@mehlon mehlon commented Apr 23, 2020

Motivation for this change

Fixes #83031

Helps make issue titles more uniform.

@ofborg ofborg bot added 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 23, 2020
@cole-h
Copy link
Member

cole-h commented Apr 24, 2020

I don't particularly see a need for this. We already assign the 0.kind: packaging request label (or rather, choosing the "packaging request" template does).

@mehlon
Copy link
Contributor Author

mehlon commented Apr 25, 2020

Of course this is not strictly necessary. But it makes the "issues" tab more visually consistent: if it starts with "Package request", it's a package request, and vice versa. Sure, there's already a label, but the label is the same blue as "bug", and is shown to the right of the issue title. Since one would read the issue title from left to right, you'd have to first read the title and then look at the label before figuring out what kind of issue it is.
Also, most people already tend to add "Package request" to their issue title anyway, so adding this would save a bit of time for them.

@stale
Copy link

stale bot commented Oct 22, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 22, 2020
@Mindavi
Copy link
Contributor

Mindavi commented Apr 28, 2022

Since this didn't get any more attention and since the comment describing they didn't see a need for it only got upvotes, I'm gonna close this.

Please reopen the discussion if you still think this is valuable, but I also don't see a lot of value in this.

@Mindavi Mindavi closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: policy discussion 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package requests should start with "Package request:"
3 participants