Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfce.xfce4-whiskermenu-plugin: 2.4.3 -> 2.4.4 #85837

Merged
merged 2 commits into from Apr 25, 2020
Merged

xfce.xfce4-whiskermenu-plugin: 2.4.3 -> 2.4.4 #85837

merged 2 commits into from Apr 25, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 23, 2020

Motivation for this change

Update to version 2.4.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CloudArtAdmins
Copy link
Contributor

I built it, "-V" works for versioning, but "-h" shows up
getttext: command not found.
Not sure if it is because i don't have another needed package, but worth mentioning.

@romildo
Copy link
Contributor Author

romildo commented Apr 23, 2020

I built it, "-V" works for versioning, but "-h" shows up
getttext: command not found.
Not sure if it is because i don't have another needed package, but worth mentioning.

Fixed.

@worldofpeace worldofpeace merged commit 9d0b4c0 into NixOS:master Apr 25, 2020
@romildo romildo deleted the upd.xfce4-whiskermenu-plugin branch April 25, 2020 17:39
@vdot0x23
Copy link
Contributor

Will this get backported to 20.03? It includes a bug fix after all :)

Fixed search delay.

https://docs.xfce.org/panel-plugins/xfce4-whiskermenu-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @CloudArtAdmins @vdot0x23 @worldofpeace